Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196353013: Convert some repaint tests to not call display() (Closed)

Created:
6 years, 9 months ago by enne (OOO)
Modified:
6 years, 9 months ago
Reviewers:
jamesr
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Visibility:
Public.

Description

Convert some repaint tests to not call display() BUG=345027 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169508

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : More expectations, remove do-not-repaint tricky test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -138 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M LayoutTests/compositing/webgl/webgl-repaint.html View 3 chunks +5 lines, -6 lines 0 comments Download
M LayoutTests/css3/flexbox/repaint.html View 1 chunk +11 lines, -6 lines 0 comments Download
M LayoutTests/css3/flexbox/repaint-column-reverse.html View 2 chunks +12 lines, -6 lines 0 comments Download
M LayoutTests/css3/flexbox/repaint-during-resize-no-flex.html View 2 chunks +10 lines, -5 lines 0 comments Download
M LayoutTests/css3/flexbox/repaint-rtl-column.html View 1 chunk +11 lines, -3 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-as-image-incremental-repaint.html View 2 chunks +3 lines, -25 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-incremental-repaint.html View 1 chunk +1 line, -12 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-incremental-repaint-2.html View 1 chunk +1 line, -13 lines 0 comments Download
M LayoutTests/fast/canvas/resources/repaint.js View 1 chunk +10 lines, -7 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-imageSmoothingEnabled-repaint.js View 1 chunk +14 lines, -30 lines 0 comments Download
M LayoutTests/fast/repaint/background-shorthand-with-gradient-and-height-changes.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/background-size-auto-with-gradient-and-height-changes.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/repaint/body-background-image.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/obscured-background-no-repaint.html View 2 chunks +3 lines, -4 lines 0 comments Download
M LayoutTests/media/audio-repaint.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/media/media-document-audio-repaint.html View 2 chunks +20 lines, -3 lines 0 comments Download
M LayoutTests/svg/foreignObject/filter-repaint.svg View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
enne (OOO)
6 years, 9 months ago (2014-03-13 20:23:57 UTC) #1
jamesr
lgtm lgtm
6 years, 9 months ago (2014-03-13 22:26:22 UTC) #2
jamesr
lgtm
6 years, 9 months ago (2014-03-13 22:26:22 UTC) #3
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-13 22:39:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/196353013/1
6 years, 9 months ago (2014-03-13 22:39:55 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 23:21:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_blink_rel
6 years, 9 months ago (2014-03-13 23:21:06 UTC) #7
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-17 18:23:22 UTC) #8
enne (OOO)
The CQ bit was unchecked by enne@chromium.org
6 years, 9 months ago (2014-03-17 18:23:24 UTC) #9
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-18 19:15:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/196353013/20001
6 years, 9 months ago (2014-03-18 19:15:56 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 19:18:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-18 19:18:21 UTC) #13
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-18 22:22:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/196353013/40001
6 years, 9 months ago (2014-03-18 22:22:57 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 22:25:06 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-18 22:25:07 UTC) #17
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-18 22:26:07 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/196353013/40001
6 years, 9 months ago (2014-03-18 22:26:11 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 23:21:02 UTC) #20
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-18 23:21:04 UTC) #21
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-18 23:27:35 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/196353013/40001
6 years, 9 months ago (2014-03-18 23:27:44 UTC) #23
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 02:45:23 UTC) #24
Message was sent while issue was closed. 
Change committed as 169508

Powered by Google App Engine
This is Rietveld 408576698