Fixed handling of polymorphic array accesses with constant index

Fix handling of polymorphic array accesses with constant index

R=jkummerow@chromium.org
BUG=chromium:351319
LOG=Y

Committed: https://code.google.com/p/v8/source/detail?r=19835

[Jakob Kummerow, 2014-03-12 09:16:24]

LGTM with a refactoring suggestion.

https://codereview.chromium.org/196353004/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

https://codereview.chromium.org/196353004/diff/1/src/hydrogen-instructions.cc...
src/hydrogen-instructions.cc:1435: static bool
CanRepresentationContainDouble(Representation rep, double value) {
nit: How about moving this to Representation::CanRepresent(double value) {...} ?

[danno, 2014-03-12 09:25:25]

This was of course my first thought, too. However, putting this in
property-details.h (that's where class Representation is completely defined)
requires including v8conversions.h and objects.h in property-details.h, which
introduces new circular header dependencies that I didn't want to have to
untable. I guess I can untangle this temporarily by adding a
property-details-inl.h, I'll do that.

[danno, 2014-03-12 10:11:47]

Committed patchset #2 manually as r19835 (tree was closed).