Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196353003: Include HTMLMediaElement.h only where needed (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
CC:
blink-reviews, nessy, gasubic, fs, eric.carlson_apple.com, Raymond Toy, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Include HTMLMediaElement.h only where needed Now slightly fewer files are recompiled when touching the header. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169411

Patch Set 1 #

Patch Set 2 : SetWrapperReferenceFrom=owner casts owner() to Node* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/html/HTMLMediaSource.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/html/MediaController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediasource/MediaSourceBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSourceBase.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webaudio/MediaElementAudioSourceNode.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/webaudio/MediaElementAudioSourceNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
philipj_slow
adamk, for you since acolwell is OOO.
6 years, 9 months ago (2014-03-12 16:53:23 UTC) #1
adamk
lgtm if it builds :)
6 years, 9 months ago (2014-03-12 18:26:37 UTC) #2
philipj_slow
On 2014/03/12 18:26:37, adamk wrote: > lgtm if it builds :) It did locally, let's ...
6 years, 9 months ago (2014-03-13 01:21:11 UTC) #3
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-13 01:21:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/196353003/1
6 years, 9 months ago (2014-03-13 01:21:27 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 01:33:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on blink_presubmit
6 years, 9 months ago (2014-03-13 01:33:12 UTC) #7
philipj_slow
Oops, also need separate LGTM for mediasource and webaudio.
6 years, 9 months ago (2014-03-13 10:13:46 UTC) #8
Ken Russell (switch to Gerrit)
webaudio lgtm
6 years, 9 months ago (2014-03-13 19:55:40 UTC) #9
acolwell GONE FROM CHROMIUM
lgtm
6 years, 9 months ago (2014-03-17 17:47:09 UTC) #10
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 9 months ago (2014-03-17 17:47:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/196353003/20001
6 years, 9 months ago (2014-03-17 17:47:27 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 17:50:03 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-17 17:50:04 UTC) #14
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-17 18:09:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/196353003/20001
6 years, 9 months ago (2014-03-17 18:09:52 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 18:10:43 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-17 18:10:46 UTC) #18
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-18 02:03:48 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/196353003/20001
6 years, 9 months ago (2014-03-18 03:15:36 UTC) #20
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 04:16:12 UTC) #21
Message was sent while issue was closed. 
Change committed as 169411

Powered by Google App Engine
This is Rietveld 408576698