Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2344)

Unified Diff: chrome/test/data/webui/md_history/history_toolbar_test.js

Issue 1963503002: MD WebUI: Add shared cr-toolbar element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor tweaks Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/md_history/history_toolbar_test.js
diff --git a/chrome/test/data/webui/md_history/history_toolbar_test.js b/chrome/test/data/webui/md_history/history_toolbar_test.js
index cb0758212114b571e9053fc3306a6b7d85f80bf5..982eee8970756bf22cbf8ea7fb58a5acddbf8114 100644
--- a/chrome/test/data/webui/md_history/history_toolbar_test.js
+++ b/chrome/test/data/webui/md_history/history_toolbar_test.js
@@ -53,16 +53,15 @@ cr.define('md_history.history_toolbar_test', function() {
test('more from this site sends and sets correct data', function(done) {
registerMessageCallback('queryHistory', this, function (info) {
dpapad 2016/05/18 23:39:13 FYI, we have established the "browser proxy" patte
tsergeant 2016/05/19 07:11:55 Cool, I'd be interested to know more.
- assertEquals(info[0], 'example.com');
+ assertEquals('example.com', info[0]);
flush(function() {
dpapad 2016/05/18 23:39:13 Unrelated to this CL, how about making flush() ret
tsergeant 2016/05/19 07:11:55 calamity@ and I talked about this yesterday, actua
- assertEquals(toolbar.$$('#search-input').$$('#search-input').value,
- 'example.com');
+ assertEquals('example.com', toolbar.$['main-toolbar'].getValue());
done();
});
});
element.$.sharedMenu.itemData = {domain: 'example.com'};
- MockInteractions.tap(element.$.menuMoreButton);
+ element.onMoreFromSiteTap_();
dpapad 2016/05/18 23:39:13 Simulating a tap action seems much better than cal
tsergeant 2016/05/19 07:11:55 In a previous version of this patch, simulating a
});
teardown(function() {

Powered by Google App Engine
This is Rietveld 408576698