MD WebUI: Add shared cr-toolbar element

chrome/browser/resources/md_history/history_toolbar.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @implements {SearchFieldDelegate}
  * @param {!HistoryToolbarElement} toolbar This history-toolbar.
  */
 function ToolbarSearchFieldDelegate(toolbar) {
@@ skipping 69 matching lines @@
 
   /**
    * When changing the search term externally, update the search field to
    * reflect the new search term.
    * @param {string} search
    */
   setSearchTerm: function(search) {
     if (this.searchTerm == search)
       return;
     this.searchTerm = search;
-    var searchField = /** @type {SearchField} */(this.$['search-input']);
-    searchField.showAndFocus().then(function(showing) {
-      if (showing) searchField.setValue(search);
+    var toolbar = /** @type {CrToolbarElement} */(this.$['main-toolbar']);

[dpapad, 2016/05/18 23:39:13]

Is toolbar expected to be null after this line? If not this should be
@type {!CrToolbarElement}

Also nit: How about changing the ID name to mainToolbar, so that you can
reference it easier from JS, like
this.$.mainToolbar

[tsergeant, 2016/05/19 07:11:55]

Closure comment: Done.

Ack on the comment about renaming the ID. We're still using kebab-case
everywhere else in history and haven't decided whether to switch to camelCase
yet, so I'd rather just stay consistent for now.

+    toolbar.showAndFocus().then(function(showing) {
+      if (showing) toolbar.setValue(search);
     });
   },
 
   /**
    * If the search term has changed reload for the new search.
    */
   onSearch: function(searchTerm) {
     if (searchTerm != this.searchTerm) {
       this.searchTerm = searchTerm;
       this.fire('search-changed', {search: searchTerm});
     }
   },
 
   attached: function() {
     this.searchFieldDelegate_ = new ToolbarSearchFieldDelegate(this);
-    /** @type {SearchField} */(this.$['search-input'])
+    /** @type {CrToolbarElement} */(this.$['main-toolbar'])

[dpapad, 2016/05/18 23:39:13]

Nit: !CrToolbarElement

[tsergeant, 2016/05/19 07:11:55]

Done.

         .setDelegate(this.searchFieldDelegate_);
   },
 
   onClearSelectionTap_: function() {
     this.fire('unselect-all');
   },
 
   onDeleteTap_: function() {
     this.fire('delete-selected');
   },
 
   /**
    * If the user is a supervised user the delete button is not shown.
    * @private
    */
   deletingAllowed_: function() {
     return loadTimeData.getBoolean('allowDeletingHistory');
   },
 
   numberOfItemsSelected_: function(count) {
     return count > 0 ? loadTimeData.getStringF('itemsSelected', count) : '';
   },
 
   getHistoryInterval_: function(queryStartTime, queryEndTime) {
     // TODO(calamity): Fix the format of these dates.
     return loadTimeData.getStringF(
       'historyInterval', queryStartTime, queryEndTime);
   }
 });