Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 19635002: MIPS: The gc should be able to traverse all AllocationSites for decision making. (Closed)

Created:
7 years, 5 months ago by kilvadyb
Modified:
7 years, 5 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: The gc should be able to traverse all AllocationSites for decision making. Port r15715 (2e830d4) Original commit message: The gc should be able to traverse all AllocationSites for decision making. The sites are threaded into a weak list. Special problems include: * Allocations of AllocationSites occur in generated code, so generated code needs to be able to add to the list. For now I have a special hydrogen instruction, though it would be nice to use general purpose instructions. * The snapshot contains AllocationSites, and these need to be re-threaded into the list on deserialization. Something nice is that the AllocationSites are only created in old space, so a special new space visitor isn't required. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 5 months ago (2013-07-17 18:07:28 UTC) #1
kisg
LGTM
7 years, 5 months ago (2013-07-17 18:28:37 UTC) #2
palfia
7 years, 5 months ago (2013-07-17 18:40:08 UTC) #3
Committed as r15732.

Powered by Google App Engine
This is Rietveld 408576698