Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1963463002: Reland of Skeleton of the overall design for the database for Pver4 (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Skeleton of the overall design for the database for Pver4 (patchset #1 id:1 of https://codereview.chromium.org/1960893002/ ) Reason for revert: This revert didn't help, the real culprit was https://codereview.chromium.org/1835823002/ Original issue's description: > Revert of Skeleton of the overall design for the database for Pver4 (patchset #5 id:80001 of https://codereview.chromium.org/1952843003/ ) > > Reason for revert: > Speculative; lots of browser tests started failing with leak reports, and all stacks contain "safe browsing". See https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/54004, e.g. > > [444:555:0506/185642:ERROR:leak_tracker.h(100)] #0 0x7fd9c5c00d0e base::debug::StackTrace::StackTrace() > #1 0x00000186cf6f base::debug::LeakTracker<>::LeakTracker() > #2 0x0000018635bb SystemURLRequestContextGetter::SystemURLRequestContextGetter() > #3 0x000001865c21 IOThread::InitSystemRequestContext() > #4 0x000001865af5 IOThread::system_url_request_context_getter() > #5 0x000001a08b90 BrowserProcessImpl::system_request_context() > #6 0x000001ef00c4 safe_browsing::SafeBrowsingService::Initialize() > #7 0x000001a0c1b0 BrowserProcessImpl::CreateSafeBrowsingService() > #8 0x000001a0c022 BrowserProcessImpl::safe_browsing_service() > > Original issue's description: > > Skeleton of the overall design for the database for Pver4 > > Design doc: https://goto.google.com/chromium-pver4-design-doc > > > > BUG==543161 > > > > Committed: https://crrev.com/8354386e0eb264960f0ccdaa9e3e003ad72f0bcd > > Cr-Commit-Position: refs/heads/master@{#392211} > > TBR=nparker@chromium.org,vakh@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG==543161 > > Committed: https://crrev.com/11fe25ad8c2112312c4f0cad5bec97047eb0befe > Cr-Commit-Position: refs/heads/master@{#392262} TBR=nparker@chromium.org,vakh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG==543161 Committed: https://crrev.com/91351e6f2237ce96a9f1ea9b67e01651311029a7 Cr-Commit-Position: refs/heads/master@{#392266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -0 lines) Patch
M components/safe_browsing_db.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M components/safe_browsing_db/BUILD.gn View 3 chunks +23 lines, -0 lines 0 comments Download
A components/safe_browsing_db/v4_database.h View 1 chunk +79 lines, -0 lines 0 comments Download
A components/safe_browsing_db/v4_database.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.h View 2 chunks +6 lines, -0 lines 0 comments Download
A components/safe_browsing_db/v4_store.h View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Created Reland of Skeleton of the overall design for the database for Pver4
4 years, 7 months ago (2016-05-07 19:30:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963463002/1
4 years, 7 months ago (2016-05-07 19:30:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-07 19:31:08 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 19:32:05 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91351e6f2237ce96a9f1ea9b67e01651311029a7
Cr-Commit-Position: refs/heads/master@{#392266}

Powered by Google App Engine
This is Rietveld 408576698