Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1963453002:
Accurately measure current persistent count while running termination GC. (Closed)
|
Created:
4 years, 7 months ago by sof Modified:
4 years, 7 months ago CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAccurately measure current persistent count while running termination GC.
Follow up on r392263 and have it really behave as wanted -- when measuring
|currentCount|, the live persistent count, while cleaning out the worker's
heap in ThreadState::runTerminationGC(), we need to initially sample it
_after_ having released thread-local static persistents. Otherwise the count
would be overestimated first time around, which could lead to prematurely
reaching a fixed point. And at a fixed point that would falsely indicate
that persistents were leaking.
R=haraken
BUG=
NOTRY=true
Committed: https://crrev.com/f95b4b4576f71a7f4e3a98b1a53be3b3bdea62ac
Cr-Commit-Position: refs/heads/master@{#392272}
Patch Set 1 #
Messages
Total messages: 15 (8 generated)
sigbjornf@opera.com changed reviewers: + oilpan-reviews@chromium.org
please take a look. with the previous, we risk leaving the loop one (or more) iterations too early.
LGTM
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963453002/1
Description was changed from ========== Accurately measure current persistent count while running termination GC. Follow up on r392263 and have it really behave as wanted -- when measuring |currentCount|, the live persistent count, while cleaning out the worker's heap in ThreadState::runTerminationGC(), we need to initially sample it _after_ having released thread-local static persistents. Otherwise the count would be overestimated first time around, which could lead to prematurely reaching a fixed point. And at a fixed point that would falsely indicate that persistents were leaking. R= BUG= ========== to ========== Accurately measure current persistent count while running termination GC. Follow up on r392263 and have it really behave as wanted -- when measuring |currentCount|, the live persistent count, while cleaning out the worker's heap in ThreadState::runTerminationGC(), we need to initially sample it _after_ having released thread-local static persistents. Otherwise the count would be overestimated first time around, which could lead to prematurely reaching a fixed point. And at a fixed point that would falsely indicate that persistents were leaking. R=haraken BUG= ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Accurately measure current persistent count while running termination GC. Follow up on r392263 and have it really behave as wanted -- when measuring |currentCount|, the live persistent count, while cleaning out the worker's heap in ThreadState::runTerminationGC(), we need to initially sample it _after_ having released thread-local static persistents. Otherwise the count would be overestimated first time around, which could lead to prematurely reaching a fixed point. And at a fixed point that would falsely indicate that persistents were leaking. R=haraken BUG= ========== to ========== Accurately measure current persistent count while running termination GC. Follow up on r392263 and have it really behave as wanted -- when measuring |currentCount|, the live persistent count, while cleaning out the worker's heap in ThreadState::runTerminationGC(), we need to initially sample it _after_ having released thread-local static persistents. Otherwise the count would be overestimated first time around, which could lead to prematurely reaching a fixed point. And at a fixed point that would falsely indicate that persistents were leaking. R=haraken BUG= NOTRY=true ==========
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963453002/1
Message was sent while issue was closed.
Description was changed from ========== Accurately measure current persistent count while running termination GC. Follow up on r392263 and have it really behave as wanted -- when measuring |currentCount|, the live persistent count, while cleaning out the worker's heap in ThreadState::runTerminationGC(), we need to initially sample it _after_ having released thread-local static persistents. Otherwise the count would be overestimated first time around, which could lead to prematurely reaching a fixed point. And at a fixed point that would falsely indicate that persistents were leaking. R=haraken BUG= NOTRY=true ========== to ========== Accurately measure current persistent count while running termination GC. Follow up on r392263 and have it really behave as wanted -- when measuring |currentCount|, the live persistent count, while cleaning out the worker's heap in ThreadState::runTerminationGC(), we need to initially sample it _after_ having released thread-local static persistents. Otherwise the count would be overestimated first time around, which could lead to prematurely reaching a fixed point. And at a fixed point that would falsely indicate that persistents were leaking. R=haraken BUG= NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Accurately measure current persistent count while running termination GC. Follow up on r392263 and have it really behave as wanted -- when measuring |currentCount|, the live persistent count, while cleaning out the worker's heap in ThreadState::runTerminationGC(), we need to initially sample it _after_ having released thread-local static persistents. Otherwise the count would be overestimated first time around, which could lead to prematurely reaching a fixed point. And at a fixed point that would falsely indicate that persistents were leaking. R=haraken BUG= NOTRY=true ========== to ========== Accurately measure current persistent count while running termination GC. Follow up on r392263 and have it really behave as wanted -- when measuring |currentCount|, the live persistent count, while cleaning out the worker's heap in ThreadState::runTerminationGC(), we need to initially sample it _after_ having released thread-local static persistents. Otherwise the count would be overestimated first time around, which could lead to prematurely reaching a fixed point. And at a fixed point that would falsely indicate that persistents were leaking. R=haraken BUG= NOTRY=true Committed: https://crrev.com/f95b4b4576f71a7f4e3a98b1a53be3b3bdea62ac Cr-Commit-Position: refs/heads/master@{#392272} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f95b4b4576f71a7f4e3a98b1a53be3b3bdea62ac Cr-Commit-Position: refs/heads/master@{#392272} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
