Make PreParser track valid left hand sides.

test/cctest/test-parsing.cc

Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index c88b2dc4464193b2cd4eee714f35df26dd50af3b..76638c31255523dfe64a2ca9322f2bdc904a5cfe 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -2526,3 +2526,69 @@ TEST(StrictDelete) {
   RunParserSyncTest(strict_context_data, bad_statement_data, kError);
   RunParserSyncTest(sloppy_context_data, bad_statement_data, kError);
 }
+
+
+TEST(ErrorInvalidLeftHandSide) {
+  const char* assignment_context_data[][2] = {
+    // {"", " = 1;"},
+    // {"\"use strict\"; ", " = 1;"},
+    { NULL, NULL }
+  };
+
+  const char* prefix_context_data[][2] = {
+    {"++", ";"},
+    {"\"use strict\"; ++", ";"},
+    {NULL, NULL},
+  };
+
+  const char* postfix_context_data[][2] = {
+    {"", "++;"},
+    {"\"use strict\"; ", "++;"},
+    { NULL, NULL }
+  };
+
+  // Good left hand sides for assigment or prefix / postfix operations.
+  const char* good_statement_data[] = {
+    "foo",
+    "foo.bar",
+    "foo[bar]",
+    "foo()[bar]",
+    "foo().bar",
+    "this.foo",
+    "this[foo]",
+    NULL
+  };
+
+  // Bad left hand sides for assigment or prefix / postfix operations.
+  const char* bad_statement_data_common[] = {
+    "2",
+    "foo()",
+    "null",
+    "if",  // Unexpected token
+    "{x: 1}",  // Unexpected token
+    "this",
+    "\"bar\"",
+    "(foo + bar)",
+    NULL
+  };
+
+  // These are not okay for assignment, but okay for prefix / postix.
+  const char* bad_statement_data_for_assignment[] = {
+    "++foo",
+    "foo++",
+    "foo + bar",
+    NULL
+  };
+
+  RunParserSyncTest(assignment_context_data, good_statement_data, kSuccess);
+  RunParserSyncTest(assignment_context_data, bad_statement_data_common, kError);
+  RunParserSyncTest(assignment_context_data, bad_statement_data_for_assignment,
+                    kError);
+
+  RunParserSyncTest(prefix_context_data, good_statement_data, kSuccess);
+  RunParserSyncTest(prefix_context_data, bad_statement_data_common, kError);
+
+  RunParserSyncTest(postfix_context_data, good_statement_data, kSuccess);
+  // TODO(marja): This doesn't work yet.

[rossberg, 2014/03/19 15:29:08]

Hm, why?

[marja, 2014/03/19 15:41:15]

Because the check is in ParsePostfixExpression which is not yet unified, and
PreParser::ParsePostFixExpression contains no check. In the working cases, the
checks are in funcs which are already moved to Base.

The division point here is that this CL just adds this tracking information, so
funcs which are in Base already get to use it. But I didn't want to add all the
checks in this CL.

I'll unify ParsePostFixExpression in the next CL and enable it. (There are a
couple of other places in parser where this check is done, and they'll also get
unified eventually.)

+  // RunParserSyncTest(postfix_context_data, bad_statement_data_common, kError);
+}