Make PreParser track valid left hand sides.

test/cctest/test-parsing.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2315 matching lines @@
     {"", ""},
     {"var f =", ""},
     { NULL, NULL }
   };
 
   const char* statement_data[] = {
     "new foo bar",
     "new ) foo",
     "new ++foo",
     // TODO(marja): Activate this test once the preparser checks correctly.
     // "new foo ++",

[rossberg, 2014/03/19 15:29:08]

Can we activate this one now?

[marja, 2014/03/19 15:41:15]

Not yet; this will start working when ParseMemberWithNewPrefixesExpression is
moved to Base.

     NULL
   };
 
   RunParserSyncTest(context_data, statement_data, kError);
 }
 
 
 TEST(StrictObjectLiteralChecking) {
   const char* strict_context_data[][2] = {
     {"\"use strict\"; var myobject = {", "};"},
@@ skipping 172 matching lines @@
 
   RunParserSyncTest(strict_context_data, sloppy_statement_data, kError);
   RunParserSyncTest(sloppy_context_data, sloppy_statement_data, kSuccess);
 
   RunParserSyncTest(strict_context_data, good_statement_data, kSuccess);
   RunParserSyncTest(sloppy_context_data, good_statement_data, kSuccess);
 
   RunParserSyncTest(strict_context_data, bad_statement_data, kError);
   RunParserSyncTest(sloppy_context_data, bad_statement_data, kError);
 }
+
+
+TEST(ErrorInvalidLeftHandSide) {
+  const char* assignment_context_data[][2] = {
+    // {"", " = 1;"},
+    // {"\"use strict\"; ", " = 1;"},
+    { NULL, NULL }
+  };
+
+  const char* prefix_context_data[][2] = {
+    {"++", ";"},
+    {"\"use strict\"; ++", ";"},
+    {NULL, NULL},
+  };
+
+  const char* postfix_context_data[][2] = {
+    {"", "++;"},
+    {"\"use strict\"; ", "++;"},
+    { NULL, NULL }
+  };
+
+  // Good left hand sides for assigment or prefix / postfix operations.
+  const char* good_statement_data[] = {
+    "foo",
+    "foo.bar",
+    "foo[bar]",
+    "foo()[bar]",
+    "foo().bar",
+    "this.foo",
+    "this[foo]",
+    NULL
+  };
+
+  // Bad left hand sides for assigment or prefix / postfix operations.
+  const char* bad_statement_data_common[] = {
+    "2",
+    "foo()",
+    "null",
+    "if",  // Unexpected token
+    "{x: 1}",  // Unexpected token
+    "this",
+    "\"bar\"",
+    "(foo + bar)",
+    NULL
+  };
+
+  // These are not okay for assignment, but okay for prefix / postix.
+  const char* bad_statement_data_for_assignment[] = {
+    "++foo",
+    "foo++",
+    "foo + bar",
+    NULL
+  };
+
+  RunParserSyncTest(assignment_context_data, good_statement_data, kSuccess);
+  RunParserSyncTest(assignment_context_data, bad_statement_data_common, kError);
+  RunParserSyncTest(assignment_context_data, bad_statement_data_for_assignment,
+                    kError);
+
+  RunParserSyncTest(prefix_context_data, good_statement_data, kSuccess);
+  RunParserSyncTest(prefix_context_data, bad_statement_data_common, kError);
+
+  RunParserSyncTest(postfix_context_data, good_statement_data, kSuccess);
+  // TODO(marja): This doesn't work yet.

[rossberg, 2014/03/19 15:29:08]

Hm, why?

[marja, 2014/03/19 15:41:15]

Because the check is in ParsePostfixExpression which is not yet unified, and
PreParser::ParsePostFixExpression contains no check. In the working cases, the
checks are in funcs which are already moved to Base.

The division point here is that this CL just adds this tracking information, so
funcs which are in Base already get to use it. But I didn't want to add all the
checks in this CL.

I'll unify ParsePostFixExpression in the next CL and enable it. (There are a
couple of other places in parser where this check is done, and they'll also get
unified eventually.)

+  // RunParserSyncTest(postfix_context_data, bad_statement_data_common, kError);
+}