LayoutTests/canvas/philip/tests/2d.imageData.object.ctor.html - Issue 196343032: Implement ImageData constructors.

Side by Side Diff: LayoutTests/canvas/philip/tests/2d.imageData.object.ctor.html

Issue 196343032: Implement ImageData constructors. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have constructor instance wrappers keep a 'data' property instead. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Canvas test: 2d.imageData.object.ctor</title>	2 <title>Canvas test: 2d.imageData.object.ctor</title>

3 <script src="../tests.js"></script>	3 <script src="../tests.js"></script>

4 <link rel="stylesheet" href="../tests.css">	4 <link rel="stylesheet" href="../tests.css">

5 <body>	5 <body>

6 <p id="passtext">Pass</p>	6 <p id="passtext">Pass</p>

7 <p id="failtext">Fail</p>	7 <p id="failtext">Fail</p>

8 <p class="output">These images should be identical:</p>	8 <p class="output">These images should be identical:</p>

9 <canvas id="c" class="output" width="100" height="50"><p class="fallback">FAIL ( fallback content)</p></canvas>	9 <canvas id="c" class="output" width="100" height="50"><p class="fallback">FAIL ( fallback content)</p></canvas>

10	10

11 <ul id="d"></ul>	11 <ul id="d"></ul>

12 <script>	12 <script>

13 _addTest(function(canvas, ctx) {	13 _addTest(function(canvas, ctx) {

14	14

15 _assertDifferent(window.ImageData, undefined, "window.ImageData", "undefined");	15 _assertDifferent(window.ImageData, undefined, "window.ImageData", "undefined");

16 try { var _thrown = false; new window.ImageData(1,1); } catch (e) { _thrown = tr ue; } finally { _assert(_thrown, "should throw exception: new window.ImageData(1 ,1)"); }	16 try { var _thrown = false; new window.ImageData(1,1); } catch (e) { _thrown = tr ue; } finally { _assert(!_thrown, "should not throw exception: new window.ImageD ata(1,1)"); }
	Inactive 2014/03/19 19:07:14 This is an imported test suite, I don't know if we This is an imported test suite, I don't know if we can update the layout test unless the original test suite is also updated. We may need to rebaseline the test for now (someone should confirm) Justin Novosad 2014/03/19 19:35:54 Correct. We only touch the baselines for these te Show quoted text On 2014/03/19 19:07:14, Chris Dumez wrote: > This is an imported test suite, I don't know if we can update the layout test > unless the original test suite is also updated. We may need to rebaseline the > test for now (someone should confirm) Correct. We only touch the baselines for these tests in the blink repo. If you need a modified version of this test, you should make a copy of it (probably under fast/canvas). Or just write a new test, as you have already done. sof 2014/03/19 22:19:16 Thanks, I reverted the pass condition inversion & Show quoted text On 2014/03/19 19:35:54, junov wrote: > On 2014/03/19 19:07:14, Chris Dumez wrote: > > This is an imported test suite, I don't know if we can update the layout test > > unless the original test suite is also updated. We may need to rebaseline the > > test for now (someone should confirm) > > Correct. We only touch the baselines for these tests in the blink repo. If you > need a modified version of this test, you should make a copy of it (probably > under fast/canvas). Or just write a new test, as you have already done. Thanks, I reverted the pass condition inversion & added a [WontFix] entry to StaleTestExpectations instead. As the test file only contains that one test, no loss in test coverage by doing so.
17	17

18	18

19 });	19 });

20 </script>	20 </script>

21	21

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/canvas/canvas-ImageData-constructor.html » ('j') | LayoutTests/fast/canvas/canvas-ImageData-constructor.html » ('J')