Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 196343024: Remove python.new.bat instead of pylint.new.bat (Closed)

Created:
6 years, 9 months ago by iannucci
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Remove python.new.bat instead of pylint.new.bat python.new.bat was inadvertantly removed when iannucci@ committed https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c64d3765a03aa66d980f66109f58eb3b05a4cb18 This restores pylint.new.bat and removes python.new.bat Original CL: https://chromiumcodereview.appspot.com/140183007/ BUG=328453 AUTHOR=techtonik@gmail.com R=agable@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
A + bootstrap/win/pylint.new.bat View 1 chunk +1 line, -2 lines 0 comments Download
D bootstrap/win/python.new.bat View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
iannucci
PTAL. This un-goofs https://chromiumcodereview.appspot.com/140183007/
6 years, 9 months ago (2014-03-17 20:31:17 UTC) #1
agable
lgtm
6 years, 9 months ago (2014-03-17 20:33:17 UTC) #2
iannucci
FTR: This happened because I needed to re-create techtonik's original CL due to CRLF issues. ...
6 years, 9 months ago (2014-03-17 20:34:30 UTC) #3
iannucci
Patchset 1 works locally (del'ing python.bat and pylint.bat, then running gclient causes python.bat and pylint.bat ...
6 years, 9 months ago (2014-03-17 20:36:39 UTC) #4
iannucci
6 years, 9 months ago (2014-03-17 20:37:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r257489 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698