Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: src/full-codegen.h

Issue 196343021: Revert "Continued fix for 351257. Reusing the feedback vector is too complex." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/factory.cc ('k') | src/full-codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 419 matching lines...) Expand 10 before | Expand all | Expand 10 after
430 Expression* sub_expr, 430 Expression* sub_expr,
431 NilValue nil); 431 NilValue nil);
432 432
433 // Bailout support. 433 // Bailout support.
434 void PrepareForBailout(Expression* node, State state); 434 void PrepareForBailout(Expression* node, State state);
435 void PrepareForBailoutForId(BailoutId id, State state); 435 void PrepareForBailoutForId(BailoutId id, State state);
436 436
437 // Feedback slot support. The feedback vector will be cleared during gc and 437 // Feedback slot support. The feedback vector will be cleared during gc and
438 // collected by the type-feedback oracle. 438 // collected by the type-feedback oracle.
439 Handle<FixedArray> FeedbackVector() { 439 Handle<FixedArray> FeedbackVector() {
440 return info_->feedback_vector(); 440 return feedback_vector_;
441 } 441 }
442 void StoreFeedbackVectorSlot(int slot, Handle<Object> object) {
443 feedback_vector_->set(slot, *object);
444 }
445 void InitializeFeedbackVector();
442 446
443 // Record a call's return site offset, used to rebuild the frame if the 447 // Record a call's return site offset, used to rebuild the frame if the
444 // called function was inlined at the site. 448 // called function was inlined at the site.
445 void RecordJSReturnSite(Call* call); 449 void RecordJSReturnSite(Call* call);
446 450
447 // Prepare for bailout before a test (or compare) and branch. If 451 // Prepare for bailout before a test (or compare) and branch. If
448 // should_normalize, then the following comparison will not handle the 452 // should_normalize, then the following comparison will not handle the
449 // canonical JS true value so we will insert a (dead) test against true at 453 // canonical JS true value so we will insert a (dead) test against true at
450 // the actual bailout target from the optimized code. If not 454 // the actual bailout target from the optimized code. If not
451 // should_normalize, the true and false labels are ignored. 455 // should_normalize, the true and false labels are ignored.
(...skipping 381 matching lines...) Expand 10 before | Expand all | Expand 10 after
833 int loop_depth_; 837 int loop_depth_;
834 ZoneList<Handle<Object> >* globals_; 838 ZoneList<Handle<Object> >* globals_;
835 Handle<FixedArray> modules_; 839 Handle<FixedArray> modules_;
836 int module_index_; 840 int module_index_;
837 const ExpressionContext* context_; 841 const ExpressionContext* context_;
838 ZoneList<BailoutEntry> bailout_entries_; 842 ZoneList<BailoutEntry> bailout_entries_;
839 GrowableBitVector prepared_bailout_ids_; 843 GrowableBitVector prepared_bailout_ids_;
840 ZoneList<BackEdgeEntry> back_edges_; 844 ZoneList<BackEdgeEntry> back_edges_;
841 int ic_total_count_; 845 int ic_total_count_;
842 Handle<FixedArray> handler_table_; 846 Handle<FixedArray> handler_table_;
847 Handle<FixedArray> feedback_vector_;
843 Handle<Cell> profiling_counter_; 848 Handle<Cell> profiling_counter_;
844 bool generate_debug_code_; 849 bool generate_debug_code_;
845 850
846 friend class NestedStatement; 851 friend class NestedStatement;
847 852
848 DEFINE_AST_VISITOR_SUBCLASS_MEMBERS(); 853 DEFINE_AST_VISITOR_SUBCLASS_MEMBERS();
849 DISALLOW_COPY_AND_ASSIGN(FullCodeGenerator); 854 DISALLOW_COPY_AND_ASSIGN(FullCodeGenerator);
850 }; 855 };
851 856
852 857
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
955 960
956 Address start_; 961 Address start_;
957 Address instruction_start_; 962 Address instruction_start_;
958 uint32_t length_; 963 uint32_t length_;
959 }; 964 };
960 965
961 966
962 } } // namespace v8::internal 967 } } // namespace v8::internal
963 968
964 #endif // V8_FULL_CODEGEN_H_ 969 #endif // V8_FULL_CODEGEN_H_
OLDNEW
« no previous file with comments | « src/factory.cc ('k') | src/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698