Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196343021: Revert "Continued fix for 351257. Reusing the feedback vector is too complex." (Closed)

Created:
6 years, 9 months ago by mvstanton
Modified:
6 years, 9 months ago
Reviewers:
bmeuer
CC:
v8-dev
Visibility:
Public.

Description

Revert "Continued fix for 351257. Reusing the feedback vector is too complex." This reverts commit r19919. TBR=bmeuer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -138 lines) Patch
M src/a64/full-codegen-a64.cc View 4 chunks +13 lines, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 4 chunks +13 lines, -1 line 0 comments Download
M src/compiler.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/compiler.cc View 4 chunks +2 lines, -17 lines 0 comments Download
M src/factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/full-codegen.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/full-codegen.cc View 3 chunks +14 lines, -2 lines 0 comments Download
M src/heap.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +14 lines, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 4 chunks +13 lines, -1 line 0 comments Download
M src/objects.h View 7 chunks +11 lines, -13 lines 0 comments Download
M src/objects.cc View 1 chunk +13 lines, -10 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/objects-inl.h View 3 chunks +5 lines, -3 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-visiting-inl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/type-info.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/type-info.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M src/typing.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +14 lines, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +2 lines, -1 line 0 comments Download
D test/mjsunit/regress/regress-351257.js View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mvstanton
Hi Benedikt, as discussed, I will approach this in a simpler way later. thx, --Michael
6 years, 9 months ago (2014-03-17 08:20:14 UTC) #1
mvstanton
6 years, 9 months ago (2014-03-17 08:31:40 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r19961 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698