Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 196343019: IPC: Make ipc_perftests run on Android. (Closed)

Created:
6 years, 9 months ago by epenner
Modified:
6 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, aelias_OOO_until_Jul13
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

IPC: Make ipc_perftests run on Android. There was several minor issues: - Base perf logging file location was off-limits on Android - Printf needs to be flushed to be visible on Android. - Android needs to reset the 'PipeMap' manually since we can't 'exec' after forking a test process. If we don't do this the Channel thinks we are in a single- process test and tries to open an FD which was closed during forking. - Android's base file descriptor needs to be increased to prevent stomping the android native logging file-descriptor with the default pipe. - The test took too long, so the 'exponent' is reduced from 5 to 3 - We need an APK With this patch the test runs like on other platforms, and lots of testing code is fixed such that it works the same way on all platforms. BUG=345471 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257877

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Addressed feedback. #

Patch Set 3 : Fix linux build. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -16 lines) Patch
M base/posix/global_descriptors.h View 1 chunk +4 lines, -0 lines 0 comments Download
M base/test/multiprocess_test_android.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M base/test/perf_log.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/test/perf_test_suite.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M ipc/ipc.gyp View 1 chunk +12 lines, -0 lines 0 comments Download
M ipc/ipc_channel.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 1 2 3 chunks +13 lines, -1 line 0 comments Download
M ipc/ipc_multiprocess_test.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ipc/ipc_perftests.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
epenner
Ptal. Needed to learn quite a bit about our multi-process tests and channels etc. to ...
6 years, 9 months ago (2014-03-15 02:19:33 UTC) #1
Nico
base/ lgtm https://codereview.chromium.org/196343019/diff/20001/ipc/ipc_channel.h File ipc/ipc_channel.h (right): https://codereview.chromium.org/196343019/diff/20001/ipc/ipc_channel.h#newcode211 ipc/ipc_channel.h:211: // process such that it act's similar ...
6 years, 9 months ago (2014-03-15 03:06:14 UTC) #2
viettrungluu
LGTM w/comments. https://codereview.chromium.org/196343019/diff/20001/base/test/perf_log.cc File base/test/perf_log.cc (right): https://codereview.chromium.org/196343019/diff/20001/base/test/perf_log.cc#newcode42 base/test/perf_log.cc:42: fflush(stdout); I'm not sure why you fflush() ...
6 years, 9 months ago (2014-03-15 17:25:27 UTC) #3
epenner
https://codereview.chromium.org/196343019/diff/20001/base/test/perf_log.cc File base/test/perf_log.cc (right): https://codereview.chromium.org/196343019/diff/20001/base/test/perf_log.cc#newcode42 base/test/perf_log.cc:42: fflush(stdout); On 2014/03/15 17:25:27, viettrungluu wrote: > I'm not ...
6 years, 9 months ago (2014-03-17 20:24:53 UTC) #4
epenner
Actually, I still need OWNERS review for IPC. The primary IPC change here is accommodating ...
6 years, 9 months ago (2014-03-17 20:30:37 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
6 years, 9 months ago (2014-03-18 17:19:50 UTC) #6
epenner
The CQ bit was checked by epenner@chromium.org
6 years, 9 months ago (2014-03-18 21:56:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/196343019/60001
6 years, 9 months ago (2014-03-18 22:12:27 UTC) #8
epenner
The CQ bit was checked by epenner@chromium.org
6 years, 9 months ago (2014-03-18 22:16:00 UTC) #9
commit-bot: I haz the power
Failed to trigger a try job on win_x64_rel HTTP Error 400: Bad Request
6 years, 9 months ago (2014-03-18 22:21:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/196343019/80001
6 years, 9 months ago (2014-03-18 22:26:00 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 22:45:42 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-18 22:45:43 UTC) #13
epenner
The CQ bit was checked by epenner@chromium.org
6 years, 9 months ago (2014-03-18 23:39:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/196343019/80001
6 years, 9 months ago (2014-03-18 23:43:08 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 06:34:54 UTC) #16
Message was sent while issue was closed.
Change committed as 257877

Powered by Google App Engine
This is Rietveld 408576698