Source/bindings/templates/attributes.cpp - Issue 196343011: document.location bindings fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 196343011: document.location bindings fix (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: + bindings update Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/attributes.cpp

diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp

index cfefd0e9f880cb89b80b9db9ebe1b5a61b61ee46..b82e2fe8129793c21901e96095ad155dd4dbb51e 100644

--- a/Source/bindings/templates/attributes.cpp

+++ b/Source/bindings/templates/attributes.cpp

@@ -232,7 +232,7 @@ v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info

{% endif %}

{% if attribute.put_forwards %}

{{cpp_class}}* proxyImp = {{v8_class}}::toNative(info.Holder());

- {{attribute.idl_type}}* imp = WTF::getPtr(proxyImp->{{attribute.name}}());

+ RefPtr<{{attribute.idl_type}}> imp = WTF::getPtr(proxyImp->{{attribute.name}}());

if (!imp)

return;

{% elif not attribute.is_static %}

« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »