add schema version to rebaseline_server intermediate JSON

add schema version to rebaseline_server intermediate JSON

NOTREECHECKS=True
NOTRY=True

Committed: http://code.google.com/p/skia/source/detail?r=13790

[epoger, 2014-03-13 15:29:19]

Ready for review at patchset 1.

This will warn us if we try to load a JSON file written by a different version
of the rebaseline_server code than the client we are running.

For now, the client ignores the version number, since the production read-only
rebaseline_server JS/HTML client will be updated immediately after this CL is
committed, but its server side process will not be restarted until later.

An hour after I commit this CL, I can create another that updates the JS/HTML
client to read and enforce the version number.

[rmistry, 2014-03-13 16:13:42]

LGTM

https://codereview.chromium.org/196343009/diff/1/gm/rebaseline_server/results.py
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/196343009/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results.py:56: KEY__HEADER__SCHEMA_VERSION_CURRENT = 1
Can we create a separate constant for the version number? This is to make it
more noticable. If I was looking to update the version number these group of
constants look like only keys to me.

Maybe something like
REBASELINE_SERVER_VERSION_NUMBER = 1.

[epoger, 2014-03-13 16:32:43]

https://codereview.chromium.org/196343009/diff/1/gm/rebaseline_server/results.py
File gm/rebaseline_server/results.py (right):

https://codereview.chromium.org/196343009/diff/1/gm/rebaseline_server/results...
gm/rebaseline_server/results.py:56: KEY__HEADER__SCHEMA_VERSION_CURRENT = 1
On 2014/03/13 16:13:43, rmistry wrote:
> Can we create a separate constant for the version number? This is to make it
> more noticable. If I was looking to update the version number these group of
> constants look like only keys to me.

You mean just because they are named KEY__* you think they are all keys ?

Good idea, done.

[epoger, 2014-03-13 16:32:47]

The CQ bit was checked by epoger@google.com

[epoger, 2014-03-13 16:32:53]

The CQ bit was unchecked by epoger@google.com

[epoger, 2014-03-13 16:33:13]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-03-13 16:33:25]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/196343009/20001

[commit-bot: I haz the power, 2014-03-13 16:33:39]

Change committed as 13790