Issue 196343003: Revert "Don't need a temp register for StoreKeyed double"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196343003: Revert "Don't need a temp register for StoreKeyed double" (Closed)

Created:
6 years, 9 months ago by haitao.feng

Modified:
6 years, 9 months ago

Reviewers:
Weiliang, Sven Panne, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Don't need a temp register for StoreKeyed double" This reverts commit r19829 for breaking the mozilla tests. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19830

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/x64/lithium-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

haitao.feng

Weiliang changed x64 port but mozilla failed on ia32 port at http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20deadcode/builds/2916. The mozilla ia32 ...

6 years, 9 months ago (2014-03-12 05:14:00 UTC) #2

Sven Panne

6 years, 9 months ago (2014-03-12 06:47:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19830 (presubmit successful).

Expand Messages | Collapse Messages