Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1963383004: Upstream: Add DEPS files to chrome/android/webapk (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 7 months ago
Reviewers:
Yaron
CC:
chromium-reviews, Xi Han
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream: Add DEPS files to WebAPK code BUG=609122 Committed: https://crrev.com/0962b106299ea71c5447228dc18b65666d756b60 Cr-Commit-Position: refs/heads/master@{#393249}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
A chrome/android/webapk/DEPS View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/android/webapk/shell_apk/DEPS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963383004/1
4 years, 7 months ago (2016-05-11 20:25:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963383004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963383004/20001
4 years, 7 months ago (2016-05-11 20:35:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963383004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963383004/40001
4 years, 7 months ago (2016-05-11 20:57:36 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-11 20:57:38 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963383004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963383004/40001
4 years, 7 months ago (2016-05-11 21:01:04 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/227360)
4 years, 7 months ago (2016-05-11 22:27:07 UTC) #12
pkotwicz
Yaron, can you please take a look?
4 years, 7 months ago (2016-05-12 02:35:38 UTC) #14
Yaron
lgtm https://codereview.chromium.org/1963383004/diff/60001/chrome/android/webapk/DEPS File chrome/android/webapk/DEPS (right): https://codereview.chromium.org/1963383004/diff/60001/chrome/android/webapk/DEPS#newcode7 chrome/android/webapk/DEPS:7: "-testing", I think we may need to add ...
4 years, 7 months ago (2016-05-12 13:39:45 UTC) #16
Yaron
lgtm https://codereview.chromium.org/1963383004/diff/60001/chrome/android/webapk/DEPS File chrome/android/webapk/DEPS (right): https://codereview.chromium.org/1963383004/diff/60001/chrome/android/webapk/DEPS#newcode7 chrome/android/webapk/DEPS:7: "-testing", On 2016/05/12 13:39:45, Yaron wrote: > I ...
4 years, 7 months ago (2016-05-12 13:58:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963383004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963383004/80001
4 years, 7 months ago (2016-05-12 14:06:16 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963383004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963383004/80001
4 years, 7 months ago (2016-05-12 14:08:36 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-12 14:51:38 UTC) #26
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 14:53:04 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0962b106299ea71c5447228dc18b65666d756b60
Cr-Commit-Position: refs/heads/master@{#393249}

Powered by Google App Engine
This is Rietveld 408576698