|
|
DescriptionUpstream: Add DEPS files to WebAPK code
BUG=609122
Committed: https://crrev.com/0962b106299ea71c5447228dc18b65666d756b60
Cr-Commit-Position: refs/heads/master@{#393249}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #
Total comments: 2
Patch Set 5 : #Messages
Total messages: 28 (15 generated)
The CQ bit was checked by pkotwicz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963383004/1
The CQ bit was checked by pkotwicz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963383004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963383004/20001
The CQ bit was checked by pkotwicz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963383004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963383004/40001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by pkotwicz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963383004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963383004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
pkotwicz@chromium.org changed reviewers: + yfriedman@chromium.org
Yaron, can you please take a look?
Description was changed from ========== Add DEPS files to chrome/android/webapk ========== to ========== Upstream: Add DEPS files to WebAPK code BUG=524670 ==========
lgtm https://codereview.chromium.org/1963383004/diff/60001/chrome/android/webapk/DEPS File chrome/android/webapk/DEPS (right): https://codereview.chromium.org/1963383004/diff/60001/chrome/android/webapk/D... chrome/android/webapk/DEPS:7: "-testing", I think we may need to add back testing if we were to have a native gtest-style test. I'm ok with this for now.
lgtm https://codereview.chromium.org/1963383004/diff/60001/chrome/android/webapk/DEPS File chrome/android/webapk/DEPS (right): https://codereview.chromium.org/1963383004/diff/60001/chrome/android/webapk/D... chrome/android/webapk/DEPS:7: "-testing", On 2016/05/12 13:39:45, Yaron wrote: > I think we may need to add back testing if we were to have a native gtest-style > test. I'm ok with this for now. ignore me. :)
The CQ bit was checked by pkotwicz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yfriedman@chromium.org Link to the patchset: https://codereview.chromium.org/1963383004/#ps80001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963383004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963383004/80001
The CQ bit was unchecked by pkotwicz@chromium.org
Description was changed from ========== Upstream: Add DEPS files to WebAPK code BUG=524670 ========== to ========== Upstream: Add DEPS files to WebAPK code BUG=609122 ==========
The CQ bit was checked by pkotwicz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963383004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963383004/80001
Message was sent while issue was closed.
Description was changed from ========== Upstream: Add DEPS files to WebAPK code BUG=609122 ========== to ========== Upstream: Add DEPS files to WebAPK code BUG=609122 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Upstream: Add DEPS files to WebAPK code BUG=609122 ========== to ========== Upstream: Add DEPS files to WebAPK code BUG=609122 Committed: https://crrev.com/0962b106299ea71c5447228dc18b65666d756b60 Cr-Commit-Position: refs/heads/master@{#393249} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/0962b106299ea71c5447228dc18b65666d756b60 Cr-Commit-Position: refs/heads/master@{#393249} |