Use explicit operator bool in scoped_refptr.

Use explicit operator bool in scoped_refptr.

Previously the "Safe Bool Idiom" was incorrectly
implemented using a typedef ... Testable that leaked
the raw pointer of scoped_refptr.

Code relying on that side effect has been corrected
in https://codereview.chromium.org/1958823002/

The C++11 explicit conversion operator feature
is now available and this hack is no longer required,
and usage will be enforced to not inadvertently
use the raw pointer.

BUG=610048
Committed: https://crrev.com/116b5a887f10705fdaf736b679f52cc84fd178d9
Cr-Commit-Position: refs/heads/master@{#393195}

[scheib, 2016-05-11 01:20:15]

Description was changed from

==========
Use explicit operator bool in scoped_refptr.

Previously the "Safe Bool Idiom" was implemented using a typedef ...
Testable work around. The C++11 explicit conversion operator feature
is now available and this hack is no longer required.

BUG=610048
==========

to

==========
Use explicit operator bool in scoped_refptr.

Previously the "Safe Bool Idiom" was incorrectly
implemented using a typedef ... Testable that leaked
the raw pointer of scoped_refptr.

The C++11 explicit conversion operator feature
is now available and this hack is no longer required,
and usage will be enforced to not inadvertently
use the raw pointer.

BUG=610048
==========

[scheib, 2016-05-11 01:20:15]

scheib@chromium.org changed reviewers:
+ danakj@chromium.org

[scheib, 2016-05-11 17:23:21]

Description was changed from

==========
Use explicit operator bool in scoped_refptr.

Previously the "Safe Bool Idiom" was incorrectly
implemented using a typedef ... Testable that leaked
the raw pointer of scoped_refptr.

The C++11 explicit conversion operator feature
is now available and this hack is no longer required,
and usage will be enforced to not inadvertently
use the raw pointer.

BUG=610048
==========

to

==========
Use explicit operator bool in scoped_refptr.

Previously the "Safe Bool Idiom" was incorrectly
implemented using a typedef ... Testable that leaked
the raw pointer of scoped_refptr.

Code relying on that side effect has been corrected
in https://codereview.chromium.org/1958823002/

The C++11 explicit conversion operator feature
is now available and this hack is no longer required,
and usage will be enforced to not inadvertently
use the raw pointer.

BUG=610048
==========

[scheib, 2016-05-11 23:03:45]

PTAL, this is the split from previous patch.

[danakj, 2016-05-12 00:15:54]

LGTM

[scheib, 2016-05-12 04:20:02]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2016-05-12 04:20:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963323004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963323004/1

[commit-bot: I haz the power, 2016-05-12 06:19:01]

Description was changed from

==========
Use explicit operator bool in scoped_refptr.

Previously the "Safe Bool Idiom" was incorrectly
implemented using a typedef ... Testable that leaked
the raw pointer of scoped_refptr.

Code relying on that side effect has been corrected
in https://codereview.chromium.org/1958823002/

The C++11 explicit conversion operator feature
is now available and this hack is no longer required,
and usage will be enforced to not inadvertently
use the raw pointer.

BUG=610048
==========

to

==========
Use explicit operator bool in scoped_refptr.

Previously the "Safe Bool Idiom" was incorrectly
implemented using a typedef ... Testable that leaked
the raw pointer of scoped_refptr.

Code relying on that side effect has been corrected
in https://codereview.chromium.org/1958823002/

The C++11 explicit conversion operator feature
is now available and this hack is no longer required,
and usage will be enforced to not inadvertently
use the raw pointer.

BUG=610048
==========

[commit-bot: I haz the power, 2016-05-12 06:19:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-12 06:20:30]

Description was changed from

==========
Use explicit operator bool in scoped_refptr.

Previously the "Safe Bool Idiom" was incorrectly
implemented using a typedef ... Testable that leaked
the raw pointer of scoped_refptr.

Code relying on that side effect has been corrected
in https://codereview.chromium.org/1958823002/

The C++11 explicit conversion operator feature
is now available and this hack is no longer required,
and usage will be enforced to not inadvertently
use the raw pointer.

BUG=610048
==========

to

==========
Use explicit operator bool in scoped_refptr.

Previously the "Safe Bool Idiom" was incorrectly
implemented using a typedef ... Testable that leaked
the raw pointer of scoped_refptr.

Code relying on that side effect has been corrected
in https://codereview.chromium.org/1958823002/

The C++11 explicit conversion operator feature
is now available and this hack is no longer required,
and usage will be enforced to not inadvertently
use the raw pointer.

BUG=610048

Committed: https://crrev.com/116b5a887f10705fdaf736b679f52cc84fd178d9
Cr-Commit-Position: refs/heads/master@{#393195}
==========

[commit-bot: I haz the power, 2016-05-12 06:20:30]

Patchset 1 (id:??) landed as
https://crrev.com/116b5a887f10705fdaf736b679f52cc84fd178d9
Cr-Commit-Position: refs/heads/master@{#393195}