Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

Issue 1963293002: Replacing Indexed DB Chromium IPC with Mojo Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Some (incomplete) work on struct traits. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
index db4a1ea7763e34fa39c8f7a7bf1e0167f75c5878..e84de86dcedc86f7e0a78f8d06809915083177b7 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
@@ -9,6 +9,7 @@
#include "bindings/modules/v8/V8BindingForModules.h"
#include "core/dom/ExceptionCode.h"
#include "modules/indexeddb/IDBDatabase.h"
+#include "modules/indexeddb/IDBDatabaseProxy.h"
#include "modules/indexeddb/IDBObserverCallback.h"
#include "modules/indexeddb/IDBObserverInit.h"
#include "modules/indexeddb/IDBTransaction.h"
@@ -46,15 +47,19 @@ void IDBObserver::observe(IDBDatabase* database, IDBTransaction* transaction, Ex
return;
}
+ // TODO(cmumford): Implement observers. This is still under construction.
+#if 0
std::unique_ptr<WebIDBObserverImpl> observer = WebIDBObserverImpl::create(this);
WebIDBObserverImpl* observerPtr = observer.get();
int32_t observerId = database->backend()->addObserver(std::move(observer), transaction->id());
m_observerIds.insert(observerId);
observerPtr->setId(observerId);
+#endif
}
void IDBObserver::unobserve(IDBDatabase* database, ExceptionState& exceptionState)
{
+#if 0
if (!database->backend()) {
exceptionState.throwDOMException(InvalidStateError, IDBDatabase::databaseClosedErrorMessage);
return;
@@ -71,6 +76,7 @@ void IDBObserver::unobserve(IDBDatabase* database, ExceptionState& exceptionStat
}
if (!observerIdsToRemove.empty())
database->backend()->removeObservers(observerIdsToRemove);
+#endif
}
void IDBObserver::removeObserver(int32_t id)

Powered by Google App Engine
This is Rietveld 408576698