Issue 1963213002: Remove 'name' from argumentNames and replace with 'argumentsNames' in UnlinkedConstructorInitialize…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1963213002: Remove 'name' from argumentNames and replace with 'argumentsNames' in UnlinkedConstructorInitialize… (Closed)

Created:
4 years, 7 months ago by scheglov

Modified:
4 years, 7 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove 'name' from argumentNames and replace with 'argumentsNames' in UnlinkedConstructorInitializer. You were right - it is not complex at all. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c7b18cb57555a350fc6ca242e0fef988ccbaff06

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+142 lines, -82 lines)			Patch
M	pkg/analyzer/lib/src/summary/format.dart	View	19 chunks	+33 lines, -31 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/format.fbs	View	Binary file		0 comments	Download
M	pkg/analyzer/lib/src/summary/idl.dart	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/resynthesize.dart	View	4 chunks	+36 lines, -32 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/summarize_const_expr.dart	View	2 chunks	+20 lines, -5 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_test.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/summary_common.dart	View	4 chunks	+36 lines, -8 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 7 months ago (2016-05-10 20:09:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c7b18cb57555a350fc6ca242e0fef988ccbaff06 (presubmit successful).