Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1963183003: WebUSB: Remove guid property from USBDevice. (Closed)

Created:
4 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 7 months ago
Reviewers:
haraken, scheib
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUSB: Remove guid property from USBDevice. The guid property has been removed from the specification and should never have been exposed to the web to begin with because while it is not stable between device connections it is the same across separate execution contexts. Since the guid property has been removed USBDevice instances must now be cached so that scripts can compare them for equality. BUG=None Committed: https://crrev.com/6868e2b9440a4d4000b8bfa7e8399ac340c35891 Cr-Commit-Position: refs/heads/master@{#395238}

Patch Set 1 #

Patch Set 2 : Update webexposed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -22 lines) Patch
M third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.h View 3 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.cpp View 5 chunks +26 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
Reilly Grant (use Gerrit)
Update webexposed.
4 years, 7 months ago (2016-05-10 22:04:08 UTC) #1
Reilly Grant (use Gerrit)
4 years, 7 months ago (2016-05-19 21:58:32 UTC) #4
Reilly Grant (use Gerrit)
4 years, 7 months ago (2016-05-19 21:58:32 UTC) #5
scheib
LGTM but update the change description for the other changes as well.
4 years, 7 months ago (2016-05-20 18:19:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963183003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963183003/20001
4 years, 7 months ago (2016-05-20 19:30:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/225967)
4 years, 7 months ago (2016-05-20 23:15:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963183003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963183003/20001
4 years, 7 months ago (2016-05-20 23:18:21 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-21 03:06:46 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6868e2b9440a4d4000b8bfa7e8399ac340c35891 Cr-Commit-Position: refs/heads/master@{#395238}
4 years, 7 months ago (2016-05-21 03:08:13 UTC) #16
haraken
4 years, 7 months ago (2016-05-21 03:14:32 UTC) #17
Message was sent while issue was closed.
Oilpan part LGTM

Powered by Google App Engine
This is Rietveld 408576698