Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1963183002: create a new message for 'Always do this' instead of using the existing one to avoid localization i… (Closed)

Created:
4 years, 7 months ago by ftang
Modified:
4 years, 7 months ago
Reviewers:
groby-ooo-7-16, msw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

create a new message for 'Always do this' instead of using the existing one to avoid localization issue. IDS_TRANSLATE_BUBBLE_ALWAYS was "Always translate" before I land https://chromium.googlesource.com/chromium/src/+/7223e2c7d071d74bcd66c5a113e97fe21a82bb68 in that cl, I change it to "Always do this" but that break the pre-existing localization. So in here I change it back to "Always translate" but create a new one IDS_TRANSLATE_BUBBLE_ALWAYS_DO_THIS for the new one. BUG=610658 Committed: https://crrev.com/ed8bfa85a2d506d4ebe5e7b9d1840fe1e59e7d6c Cr-Commit-Position: refs/heads/master@{#392729}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
ftang
please review :)
4 years, 7 months ago (2016-05-10 18:33:48 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963183002/1
4 years, 7 months ago (2016-05-10 18:33:57 UTC) #4
ftang
4 years, 7 months ago (2016-05-10 18:34:54 UTC) #6
msw
lgtm
4 years, 7 months ago (2016-05-10 18:39:56 UTC) #8
groby-ooo-7-16
LGTM
4 years, 7 months ago (2016-05-10 18:48:14 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-10 19:51:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963183002/1
4 years, 7 months ago (2016-05-10 21:32:56 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 21:38:46 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 21:40:32 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed8bfa85a2d506d4ebe5e7b9d1840fe1e59e7d6c
Cr-Commit-Position: refs/heads/master@{#392729}

Powered by Google App Engine
This is Rietveld 408576698