Web MIDI: Tune Request [0xf6] wasn't handled correctly.

Web MIDI: Tune Request [0xf6] wasn't handled correctly.

Tune Request is one of System Common Messages, but is a special because
only this message type has no data. This message wasn't handled
correctly before this change.

BUG=610116
Committed: https://crrev.com/34b2ef7758db06aedf73e707d591292e61eee7c9
Cr-Commit-Position: refs/heads/master@{#393192}

[Takashi Toyoshima, 2016-05-10 09:41:47]

Description was changed from

==========
Web MIDI: Tune Request [0xf6] wasn't handled correctly.

Tune Request is one of System Common Messages, but is a special because
only this message type has no data. This message wasn't handled
correctly before this change.

BUG=610116
==========

to

==========
Web MIDI: Tune Request [0xf6] wasn't handled correctly.

Tune Request is one of System Common Messages, but is a special because
only this message type has no data. This message wasn't handled
correctly before this change.

BUG=610116
==========

[Takashi Toyoshima, 2016-05-10 09:41:47]

toyoshim@chromium.org changed reviewers:
+ yhirano@chromium.org

[Takashi Toyoshima, 2016-05-10 09:41:55]

PTAL

[yhirano, 2016-05-10 16:08:24]

lgtm

https://codereview.chromium.org/1963063002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webmidi/send-system-messages.html (right):

https://codereview.chromium.org/1963063002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webmidi/send-system-messages.html:39:
shouldNotThrow('output.send(message)');
optional: You don't need shouldNotThrow because if an exception is thrown that
will be caught by the rejection handler.

https://codereview.chromium.org/1963063002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp (right):

https://codereview.chromium.org/1963063002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp:149:
DCHECK(!isRealTimeMessage());
DCHECK(!isEndOfSysEx());

https://codereview.chromium.org/1963063002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp:152: size_t length =
isSystemMessage() ? systemMessageLength[m_data[m_offset] - 0xf1] :
channelMessageLength[(m_data[m_offset] >> 4) - 8];
DCHECK_GT(length, 0);

[Takashi Toyoshima, 2016-05-11 05:59:16]

https://codereview.chromium.org/1963063002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webmidi/send-system-messages.html (right):

https://codereview.chromium.org/1963063002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webmidi/send-system-messages.html:39:
shouldNotThrow('output.send(message)');
On 2016/05/10 16:08:24, yhirano wrote:
> optional: You don't need shouldNotThrow because if an exception is thrown that
> will be caught by the rejection handler.

Done.

https://codereview.chromium.org/1963063002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp (right):

https://codereview.chromium.org/1963063002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp:149:
DCHECK(!isRealTimeMessage());
On 2016/05/10 16:08:24, yhirano wrote:
> DCHECK(!isEndOfSysEx());

Done.

https://codereview.chromium.org/1963063002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp:152: size_t length =
isSystemMessage() ? systemMessageLength[m_data[m_offset] - 0xf1] :
channelMessageLength[(m_data[m_offset] >> 4) - 8];
Good point.
I also added new test items that inputs reserved system messages, and system
exclusive messages to confirm if exceptions are thrown correctly.

[Takashi Toyoshima, 2016-05-11 05:59:40]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 05:59:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963063002/40001

[commit-bot: I haz the power, 2016-05-11 08:09:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 08:09:10]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Takashi Toyoshima, 2016-05-11 09:51:38]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-05-11 09:51:38]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/1963063002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-05-11 09:51:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963063002/40001

[commit-bot: I haz the power, 2016-05-11 13:43:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 13:43:09]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Takashi Toyoshima, 2016-05-12 03:27:46]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-05-12 03:28:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963063002/40001

[commit-bot: I haz the power, 2016-05-12 05:37:10]

Description was changed from

==========
Web MIDI: Tune Request [0xf6] wasn't handled correctly.

Tune Request is one of System Common Messages, but is a special because
only this message type has no data. This message wasn't handled
correctly before this change.

BUG=610116
==========

to

==========
Web MIDI: Tune Request [0xf6] wasn't handled correctly.

Tune Request is one of System Common Messages, but is a special because
only this message type has no data. This message wasn't handled
correctly before this change.

BUG=610116
==========

[commit-bot: I haz the power, 2016-05-12 05:37:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-12 05:38:29]

Description was changed from

==========
Web MIDI: Tune Request [0xf6] wasn't handled correctly.

Tune Request is one of System Common Messages, but is a special because
only this message type has no data. This message wasn't handled
correctly before this change.

BUG=610116
==========

to

==========
Web MIDI: Tune Request [0xf6] wasn't handled correctly.

Tune Request is one of System Common Messages, but is a special because
only this message type has no data. This message wasn't handled
correctly before this change.

BUG=610116

Committed: https://crrev.com/34b2ef7758db06aedf73e707d591292e61eee7c9
Cr-Commit-Position: refs/heads/master@{#393192}
==========

[commit-bot: I haz the power, 2016-05-12 05:38:30]

Patchset 3 (id:??) landed as
https://crrev.com/34b2ef7758db06aedf73e707d591292e61eee7c9
Cr-Commit-Position: refs/heads/master@{#393192}