Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 1962953002: Storage of ComputedStyle separate from LayoutObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Node.cpp
diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp
index ffb377480adadff7c42dd82b2acc81f345dfbd2f..95e4076049dbc380daa5bca4d817879938295168 100644
--- a/third_party/WebKit/Source/core/dom/Node.cpp
+++ b/third_party/WebKit/Source/core/dom/Node.cpp
@@ -264,6 +264,8 @@ Node::~Node()
// this condition (we cannot directly access it here.)
RELEASE_ASSERT(hasRareData() || !layoutObject());
InstanceCounters::decrementCounter(InstanceCounters::NodeCounter);
+ if (!hasRareData() && !hasLayoutObject() && m_data.m_computedStyle)
esprehn 2016/08/05 21:26:26 !hasLayoutObject() doesn't make sense here, you ca
Bugs Nash 2016/08/12 03:55:33 Done
+ m_data.m_computedStyle->deref();
}
NodeRareData* Node::rareData() const
@@ -278,9 +280,9 @@ NodeRareData& Node::ensureRareData()
return *rareData();
if (isElementNode())
- m_data.m_rareData = ElementRareData::create(m_data.m_layoutObject);
+ m_data.m_rareData = ElementRareData::create(layoutObject());
else
- m_data.m_rareData = NodeRareData::create(m_data.m_layoutObject);
+ m_data.m_rareData = NodeRareData::create(layoutObject());
DCHECK(m_data.m_rareData);

Powered by Google App Engine
This is Rietveld 408576698