third_party/WebKit/Source/core/dom/NodeRareData.h - Issue 1962953002: Storage of ComputedStyle separate from LayoutObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/NodeRareData.h

Issue 1962953002: Storage of ComputedStyle separate from LayoutObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed ComputedStyle from NodeRareData, instead use existing ComputedStyle from ElementRareData Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Node.h ('K') | « third_party/WebKit/Source/core/dom/NodeComputedStyle.h ('k') | third_party/WebKit/Source/core/dom/NodeRareData.cpp » ('j') | third_party/WebKit/Source/core/dom/NodeRareData.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/NodeRareData.h

diff --git a/third_party/WebKit/Source/core/dom/NodeRareData.h b/third_party/WebKit/Source/core/dom/NodeRareData.h

index 5103db6194cbe99101c1a70726b6d6117c71ca65..694288ff0fc8fae0ad45fee8ebfe440f5f550ce6 100644

--- a/third_party/WebKit/Source/core/dom/NodeRareData.h

+++ b/third_party/WebKit/Source/core/dom/NodeRareData.h

@@ -24,6 +24,7 @@

#include "core/dom/MutationObserverRegistration.h"

#include "core/dom/NodeListsNodeData.h"

+#include "core/style/ComputedStyle.h"

Timothy Loh 2016/06/23 23:58:02 not needed?

#include "platform/heap/Handle.h"

#include "wtf/HashSet.h"

@@ -93,6 +94,8 @@ public:

--m_connectedFrameCount;

}

+ bool isElementRareData() const { return m_isElementRareData; }

bool hasElementFlag(ElementFlags mask) const { return m_elementFlags & mask; }

void setElementFlag(ElementFlags mask, bool value) { m_elementFlags = (m_elementFlags & ~mask) | (-(int32_t)value & mask); }

void clearElementFlag(ElementFlags mask) { m_elementFlags &= ~mask; }