third_party/WebKit/Source/core/dom/NodeRareData.h - Issue 1962953002: Storage of ComputedStyle separate from LayoutObject.

Side by Side Diff: third_party/WebKit/Source/core/dom/NodeRareData.h

Issue 1962953002: Storage of ComputedStyle separate from LayoutObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/dom/NodeComputedStyle.h ('K') | « third_party/WebKit/Source/core/dom/NodeComputedStyle.h ('k') | third_party/WebKit/Source/core/dom/NodeRareData.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2008, 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2008, 2010 Apple Inc. All rights reserved.

3 * Copyright (C) 2008 David Smith <catfish.man@gmail.com>	3 * Copyright (C) 2008 David Smith <catfish.man@gmail.com>

4 *	4 *

5 * This library is free software; you can redistribute it and/or	5 * This library is free software; you can redistribute it and/or

6 * modify it under the terms of the GNU Library General Public	6 * modify it under the terms of the GNU Library General Public

7 * License as published by the Free Software Foundation; either	7 * License as published by the Free Software Foundation; either

8 * version 2 of the License, or (at your option) any later version.	8 * version 2 of the License, or (at your option) any later version.

9 *	9 *

10 * This library is distributed in the hope that it will be useful,	10 * This library is distributed in the hope that it will be useful,

(...skipping 75 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
86 }	86 }

87	87

88 unsigned connectedSubframeCount() const { return m_connectedFrameCount; }	88 unsigned connectedSubframeCount() const { return m_connectedFrameCount; }

89 void incrementConnectedSubframeCount();	89 void incrementConnectedSubframeCount();

90 void decrementConnectedSubframeCount()	90 void decrementConnectedSubframeCount()

91 {	91 {

92 DCHECK(m_connectedFrameCount);	92 DCHECK(m_connectedFrameCount);

93 --m_connectedFrameCount;	93 --m_connectedFrameCount;

94 }	94 }

95	95

	96 bool isElementRareData() const { return m_isElementRareData; }
	esprehn 2016/08/05 21:26:26 you don't need this if you move computedStyle()/ s you don't need this if you move computedStyle()/ setComputedStyle/clearComputedStyle to NodeRareData and RefPtr<ComputedStyle> m_computedStyle; there as well.
	97

96 bool hasElementFlag(ElementFlags mask) const { return m_elementFlags & mask; }	98 bool hasElementFlag(ElementFlags mask) const { return m_elementFlags & mask; }

97 void setElementFlag(ElementFlags mask, bool value) { m_elementFlags = (m_ele mentFlags & ~mask) \| (-(int32_t)value & mask); }	99 void setElementFlag(ElementFlags mask, bool value) { m_elementFlags = (m_ele mentFlags & ~mask) \| (-(int32_t)value & mask); }

98 void clearElementFlag(ElementFlags mask) { m_elementFlags &= ~mask; }	100 void clearElementFlag(ElementFlags mask) { m_elementFlags &= ~mask; }

99	101

100 bool hasRestyleFlag(DynamicRestyleFlags mask) const { return m_restyleFlags & mask; }	102 bool hasRestyleFlag(DynamicRestyleFlags mask) const { return m_restyleFlags & mask; }

101 void setRestyleFlag(DynamicRestyleFlags mask) { m_restyleFlags \|= mask; RELE ASE_ASSERT(m_restyleFlags); }	103 void setRestyleFlag(DynamicRestyleFlags mask) { m_restyleFlags \|= mask; RELE ASE_ASSERT(m_restyleFlags); }

102 bool hasRestyleFlags() const { return m_restyleFlags; }	104 bool hasRestyleFlags() const { return m_restyleFlags; }

103 void clearRestyleFlags() { m_restyleFlags = 0; }	105 void clearRestyleFlags() { m_restyleFlags = 0; }

104	106

105 enum {	107 enum {

(...skipping 24 matching lines...) Expand all Loading...
130 unsigned m_connectedFrameCount : ConnectedFrameCountBits;	132 unsigned m_connectedFrameCount : ConnectedFrameCountBits;

131 unsigned m_elementFlags : NumberOfElementFlags;	133 unsigned m_elementFlags : NumberOfElementFlags;

132 unsigned m_restyleFlags : NumberOfDynamicRestyleFlags;	134 unsigned m_restyleFlags : NumberOfDynamicRestyleFlags;

133 protected:	135 protected:

134 unsigned m_isElementRareData : 1;	136 unsigned m_isElementRareData : 1;

135 };	137 };

136	138

137 } // namespace blink	139 } // namespace blink

138	140

139 #endif // NodeRareData_h	141 #endif // NodeRareData_h

OLD	NEW