Fix rendering of flash content inside an out-of-process iframe.

Fix rendering of flash content inside an out-of-process iframe.

This patch moves the tracking of pepper plugins from RenderViewImpl to
RenderWidget.

BUG=593520
Committed: https://crrev.com/e0c2792eceaa5dded2926522bcfd16a5c295a46f
Cr-Commit-Position: refs/heads/master@{#393012}

[lfg, 2016-05-10 18:41:52]

lfg@chromium.org changed reviewers:
+ avi@chromium.org

[lfg, 2016-05-10 18:41:53]

Avi, please take a look. This fixes the rendering of flash content, but there
will still be some more disentanglement needed to be done afterwards in
RenderView/RenderWidget with respect to plugins (mainly IME for pepper
instances).

[lfg, 2016-05-10 18:42:47]

Description was changed from

==========
Fix rendering of flash content inside an out-of-process iframe.

This patch moves the tracking of pepper plugins from RenderViewImpl to
RenderWidget.

BUG=593520
==========

to

==========
Fix rendering of flash content inside an out-of-process iframe.

This patch moves the tracking of pepper plugins from RenderViewImpl to
RenderWidget.

BUG=593520
==========

[Avi (use Gerrit), 2016-05-10 18:46:02]

I lean towards LG, but are plugins a widget thing rather than a frame thing?

[dcheng, 2016-05-10 18:57:58]

https://codereview.chromium.org/1962923002/diff/20001/content/renderer/render...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/1962923002/diff/20001/content/renderer/render...
content/renderer/render_widget.cc:628: for (PepperPluginSet::iterator i =
active_pepper_instances_.begin();
Drive-by: I know the original code was written like this, but consider just
writing:

for (auto* plugin_instance : active_pepper_instances_)
  plugin_instance->PageVisibilityChanged(...);

here and below.

[lfg, 2016-05-10 19:41:32]

On 2016/05/10 18:46:02, Avi wrote:
> I lean towards LG, but are plugins a widget thing rather than a frame thing?

That's a good point. They are definitely related to the widget, but we could
probably track them in RF and have the widget notify the frame. Let me try that
approach.

[lfg, 2016-05-11 16:21:55]

Avi, please take another look. I've refactored the patch so that plugins are
tracked per-frame instead of per-widget.

[Avi (use Gerrit), 2016-05-11 18:15:11]

lgtm

[lfg, 2016-05-11 18:33:20]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2016-05-11 18:34:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1962923002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1962923002/100001

[commit-bot: I haz the power, 2016-05-11 18:52:19]

Description was changed from

==========
Fix rendering of flash content inside an out-of-process iframe.

This patch moves the tracking of pepper plugins from RenderViewImpl to
RenderWidget.

BUG=593520
==========

to

==========
Fix rendering of flash content inside an out-of-process iframe.

This patch moves the tracking of pepper plugins from RenderViewImpl to
RenderWidget.

BUG=593520
==========

[commit-bot: I haz the power, 2016-05-11 18:52:20]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-11 18:53:59]

Description was changed from

==========
Fix rendering of flash content inside an out-of-process iframe.

This patch moves the tracking of pepper plugins from RenderViewImpl to
RenderWidget.

BUG=593520
==========

to

==========
Fix rendering of flash content inside an out-of-process iframe.

This patch moves the tracking of pepper plugins from RenderViewImpl to
RenderWidget.

BUG=593520

Committed: https://crrev.com/e0c2792eceaa5dded2926522bcfd16a5c295a46f
Cr-Commit-Position: refs/heads/master@{#393012}
==========

[commit-bot: I haz the power, 2016-05-11 18:54:00]

Patchset 6 (id:??) landed as
https://crrev.com/e0c2792eceaa5dded2926522bcfd16a5c295a46f
Cr-Commit-Position: refs/heads/master@{#393012}