Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Issue 1962913002: win/gn: Make building chromoting.msi work in 32-bit official builds. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
Sergey Ulanov, Hzj_jie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win/gn: Make building chromoting.msi work in 32-bit official builds. BUG=610445, 512899 TBR=sergeyu Committed: https://crrev.com/7bd26f185bdbf8762bf69cdc6b4d8834e5e2b968 Cr-Commit-Position: refs/heads/master@{#392478}

Patch Set 1 #

Patch Set 2 : simpler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M remoting/host/BUILD.gn View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Nico
With this, everything builds fine in 32-bit official builds. I'd recommend doing a 32-bit build ...
4 years, 7 months ago (2016-05-09 22:42:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962913002/20001
4 years, 7 months ago (2016-05-09 22:42:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 23:46:10 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 23:47:28 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7bd26f185bdbf8762bf69cdc6b4d8834e5e2b968
Cr-Commit-Position: refs/heads/master@{#392478}

Powered by Google App Engine
This is Rietveld 408576698