Make GYP and GN build consistent for third_party targets

third_party/third_party.gyp

 # Copyright 2014 PDFium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'pdf_enable_xfa%': 0,  # Set to 1 by standalone.gypi in standalone builds.
     'pdf_use_skia%': 0,
   },
   'target_defaults': {
     'defines': [
       'OPJ_STATIC',
       'PNG_PREFIX',
       'PNG_USE_READ_MACROS',
     ],
     'include_dirs': [
       # This is implicit in GN.
       '<(DEPTH)',
       '..',
     ],
-    'msvs_disabled_warnings': [
-      4018, 4146, 4333, 4345, 4267
-    ],
   },
   'targets': [
     {
       'target_name': 'bigint',
       'type': 'static_library',
       'sources': [
         'bigint/BigInteger.hh',
         'bigint/BigIntegerLibrary.hh',
         'bigint/BigIntegerUtils.hh',
         'bigint/BigUnsigned.hh',
@@ skipping 55 matching lines @@
           ],
         }],
       ],
       'variables': {
         'clang_warning_flags': [
           # open_face_PS_from_sfnt_stream() and open_face_from_buffer() in
           # ftbase.h are unused.
           '-Wno-unused-function',
         ],
       },
+      'msvs_disabled_warnings': [
+        # Warnings about conversion from 'size_t' to 'long', possible loss of
+        # data.
+        4267,
+      ],
     },
     {
       'target_name': 'fx_agg',
       'type': 'static_library',
       'sources': [
         'agg23/agg_basics.h',
         'agg23/agg_clip_liang_barsky.h',
         'agg23/agg_conv_dash.h',
         'agg23/agg_conv_stroke.h',
         'agg23/agg_curves.cpp',
@@ skipping 137 matching lines @@
             '-Wno-shift-negative-value',
             '-Wno-unused',
           ],
         }],
       ],
       'variables': {
         'clang_warning_flags': [
           # Avoid warning for undefined behaviour.
           '-Wno-shift-negative-value',
         ],
-      }
+      },
+      'msvs_disabled_warnings': [
+        # Warnings about conversion from 'size_t' to 'long', possible loss of
+        # data.
+        4267,
+      ],
     },
     {
       'target_name': 'fx_libopenjpeg',
       'type': 'static_library',
       'sources': [
         'libopenjpeg20/bio.c',
         'libopenjpeg20/cio.c',
         'libopenjpeg20/dwt.c',
         'libopenjpeg20/event.c',
         'libopenjpeg20/function_list.c',
         'libopenjpeg20/image.c',
         'libopenjpeg20/invert.c',
         'libopenjpeg20/j2k.c',
         'libopenjpeg20/jp2.c',
         'libopenjpeg20/mct.c',
         'libopenjpeg20/mqc.c',
         'libopenjpeg20/openjpeg.c',
         'libopenjpeg20/opj_clock.c',
         'libopenjpeg20/pi.c',
         'libopenjpeg20/raw.c',
         'libopenjpeg20/t1.c',
         'libopenjpeg20/t2.c',
         'libopenjpeg20/tcd.c',
         'libopenjpeg20/tgt.c',
       ],
+      'msvs_disabled_warnings': [
+        4018,
+      ],
     },
     {
       'target_name': 'fx_lpng',
       'type': 'static_library',
       'sources': [
         'libpng16/png.c',
         'libpng16/png.h',
         'libpng16/pngconf.h',
         'libpng16/pngdebug.h',
         'libpng16/pngerror.c',
@@ skipping 114 matching lines @@
             'libtiff/tif_thunder.c',
             'libtiff/tif_tile.c',
             'libtiff/tif_version.c',
             'libtiff/tif_warning.c',
             'libtiff/tif_write.c',
             'libtiff/tif_zip.c',
           ],
           'conditions': [
             ['OS=="win"', {
               'defines!': [
-                 # Need to undefine the macro since it is redefined in
-                 # tif_ojpeg.c and tif_jpeg.c.
+                # Need to undefine the macro since it is redefined in
+                # tif_ojpeg.c and tif_jpeg.c.
                 'WIN32_LEAN_AND_MEAN',
               ],
             }],
           ],
         },
       ],
     }],
   ],
 }