[Payments] Animate the scrim and bottom sheet disappearing

[Payments] Animate the scrim and bottom sheet disappearing

* When the user moves further along in the flow, animate the
  PaymentRequestUI bottom sheet disappearing.

* When the dialog is dismissed, animate the scrim fading out
  when they're on the initial sheet.  The dialog should just
  blink out of existence when the floaty PaymentResultUI is
  being displayed.

* Disable clicking on the scrim to dismiss the dialog.

* Remove the "Payment processed" dialog from PaymentResultUI.

* Slightly cleanup the onAnimationStart calls, which shouldn't
  be necessary.  I added them originally because of bugs in the
  old Animation framework, which shouldn't be problematic for
  the Animator framework.

BUG=603635
Committed: https://crrev.com/6a576669a0f7a301d3eaff980c9e1250e617fa87
Cr-Commit-Position: refs/heads/master@{#392513}

[gone, 2016-05-09 23:10:15]

Description was changed from

==========
[Payments] Animate the scrim and bottom sheet disappearing

* When the user moves further along in the flow, animate the
  PaymentRequestUI bottom sheet disappearing.

* When the dialog is dismissed, animate the scrim fading out.

BUG=603635
==========

to

==========
[Payments] Animate the scrim and bottom sheet disappearing

* When the user moves further along in the flow, animate the
  PaymentRequestUI bottom sheet disappearing.

* When the dialog is dismissed, animate the scrim fading out
  when they're on the initial sheet.  The dialog should just
  blink out of existence when the floaty PaymentResultUI is
  being displayed.

* Disable clicking on the scrim to dismiss the dialog.

* Remove the "Payment processed" dialog from PaymentResultUI.

BUG=603635
==========

[gone, 2016-05-09 23:31:26]

Description was changed from

==========
[Payments] Animate the scrim and bottom sheet disappearing

* When the user moves further along in the flow, animate the
  PaymentRequestUI bottom sheet disappearing.

* When the dialog is dismissed, animate the scrim fading out
  when they're on the initial sheet.  The dialog should just
  blink out of existence when the floaty PaymentResultUI is
  being displayed.

* Disable clicking on the scrim to dismiss the dialog.

* Remove the "Payment processed" dialog from PaymentResultUI.

BUG=603635
==========

to

==========
[Payments] Animate the scrim and bottom sheet disappearing

* When the user moves further along in the flow, animate the
  PaymentRequestUI bottom sheet disappearing.

* When the dialog is dismissed, animate the scrim fading out
  when they're on the initial sheet.  The dialog should just
  blink out of existence when the floaty PaymentResultUI is
  being displayed.

* Disable clicking on the scrim to dismiss the dialog.

* Remove the "Payment processed" dialog from PaymentResultUI.

* Slightly cleanup the onAnimationStart calls, which shouldn't
  be necessary.  I added them originally because of bugs in the
  old Animation framework, which shouldn't be problematic for
  the Animator framework.

BUG=603635
==========

[gone, 2016-05-09 23:43:40]

dfalcantara@chromium.org changed reviewers:
+ rouslan@chromium.org, twellington@chromium.org

[gone, 2016-05-09 23:43:40]

rouslan@ for the functional changes.  Mainly for removing the extra Payment
processed screen.

twellington@ for animation changes.

[please use gerrit instead, 2016-05-10 00:15:18]

lgtm

[Theresa, 2016-05-10 00:53:55]

lgtm

https://codereview.chromium.org/1962833002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
(right):

https://codereview.chromium.org/1962833002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:738:
mBottomSheetContainer, View.TRANSLATION_Y, 0, mAnimatorTranslation);
nit: 0f?

[gone, 2016-05-10 00:58:44]

https://codereview.chromium.org/1962833002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
(right):

https://codereview.chromium.org/1962833002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:738:
mBottomSheetContainer, View.TRANSLATION_Y, 0, mAnimatorTranslation);
On 2016/05/10 00:53:55, Theresa Wellington wrote:
> nit: 0f?

Done.

[gone, 2016-05-10 00:58:54]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-05-10 00:58:54]

The CQ bit was unchecked by dfalcantara@chromium.org

[gone, 2016-05-10 00:58:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/1962833002/#ps80001
(title: "Nits")

[gone, 2016-05-10 00:58:55]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-05-10 00:59:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1962833002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1962833002/80001

[commit-bot: I haz the power, 2016-05-10 01:50:44]

Description was changed from

==========
[Payments] Animate the scrim and bottom sheet disappearing

* When the user moves further along in the flow, animate the
  PaymentRequestUI bottom sheet disappearing.

* When the dialog is dismissed, animate the scrim fading out
  when they're on the initial sheet.  The dialog should just
  blink out of existence when the floaty PaymentResultUI is
  being displayed.

* Disable clicking on the scrim to dismiss the dialog.

* Remove the "Payment processed" dialog from PaymentResultUI.

* Slightly cleanup the onAnimationStart calls, which shouldn't
  be necessary.  I added them originally because of bugs in the
  old Animation framework, which shouldn't be problematic for
  the Animator framework.

BUG=603635
==========

to

==========
[Payments] Animate the scrim and bottom sheet disappearing

* When the user moves further along in the flow, animate the
  PaymentRequestUI bottom sheet disappearing.

* When the dialog is dismissed, animate the scrim fading out
  when they're on the initial sheet.  The dialog should just
  blink out of existence when the floaty PaymentResultUI is
  being displayed.

* Disable clicking on the scrim to dismiss the dialog.

* Remove the "Payment processed" dialog from PaymentResultUI.

* Slightly cleanup the onAnimationStart calls, which shouldn't
  be necessary.  I added them originally because of bugs in the
  old Animation framework, which shouldn't be problematic for
  the Animator framework.

BUG=603635
==========

[commit-bot: I haz the power, 2016-05-10 01:50:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-10 01:52:15]

Description was changed from

==========
[Payments] Animate the scrim and bottom sheet disappearing

* When the user moves further along in the flow, animate the
  PaymentRequestUI bottom sheet disappearing.

* When the dialog is dismissed, animate the scrim fading out
  when they're on the initial sheet.  The dialog should just
  blink out of existence when the floaty PaymentResultUI is
  being displayed.

* Disable clicking on the scrim to dismiss the dialog.

* Remove the "Payment processed" dialog from PaymentResultUI.

* Slightly cleanup the onAnimationStart calls, which shouldn't
  be necessary.  I added them originally because of bugs in the
  old Animation framework, which shouldn't be problematic for
  the Animator framework.

BUG=603635
==========

to

==========
[Payments] Animate the scrim and bottom sheet disappearing

* When the user moves further along in the flow, animate the
  PaymentRequestUI bottom sheet disappearing.

* When the dialog is dismissed, animate the scrim fading out
  when they're on the initial sheet.  The dialog should just
  blink out of existence when the floaty PaymentResultUI is
  being displayed.

* Disable clicking on the scrim to dismiss the dialog.

* Remove the "Payment processed" dialog from PaymentResultUI.

* Slightly cleanup the onAnimationStart calls, which shouldn't
  be necessary.  I added them originally because of bugs in the
  old Animation framework, which shouldn't be problematic for
  the Animator framework.

BUG=603635

Committed: https://crrev.com/6a576669a0f7a301d3eaff980c9e1250e617fa87
Cr-Commit-Position: refs/heads/master@{#392513}
==========

[commit-bot: I haz the power, 2016-05-10 01:52:16]

Patchset 5 (id:??) landed as
https://crrev.com/6a576669a0f7a301d3eaff980c9e1250e617fa87
Cr-Commit-Position: refs/heads/master@{#392513}