Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196283015: Revert "Moved type feedback vector to SharedFunctionInfo." (Closed)

Created:
6 years, 9 months ago by Hannes Payer (out of office)
Modified:
6 years, 9 months ago
Reviewers:
titzer, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Revert "Moved type feedback vector to SharedFunctionInfo." This reverts commit 828f1d563a3f0972135886888fd26526e04da07f. Conflicts: src/compiler.cc test/cctest/test-compiler.cc BUG= R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -166 lines) Patch
M src/a64/full-codegen-a64.cc View 4 chunks +13 lines, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 4 chunks +13 lines, -1 line 0 comments Download
M src/compiler.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/compiler.cc View 5 chunks +2 lines, -27 lines 0 comments Download
M src/factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/full-codegen.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/full-codegen.cc View 3 chunks +14 lines, -2 lines 0 comments Download
M src/heap.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +14 lines, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 4 chunks +13 lines, -1 line 0 comments Download
M src/objects.h View 7 chunks +11 lines, -13 lines 0 comments Download
M src/objects.cc View 1 chunk +13 lines, -10 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/objects-inl.h View 3 chunks +5 lines, -3 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-visiting-inl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/type-info.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/type-info.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M src/typing.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +14 lines, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
6 years, 9 months ago (2014-03-13 17:45:55 UTC) #1
titzer
On 2014/03/13 17:45:55, Hannes Payer wrote: LGTM, leider. Arme Michael!
6 years, 9 months ago (2014-03-13 17:46:47 UTC) #2
Hannes Payer (out of office)
Committed patchset #1 manually as r19911 (presubmit successful).
6 years, 9 months ago (2014-03-13 17:47:31 UTC) #3
Jakob Kummerow
6 years, 9 months ago (2014-03-13 19:41:23 UTC) #4
Message was sent while issue was closed. 
Reminder: please use SVN revision numbers in revert commit descriptions. The Git
hashes are unique to your checkout, they're not useful for anyone else.

Powered by Google App Engine
This is Rietveld 408576698