content/browser/web_contents/web_contents_impl.cc - Issue 196283013: Make to call WebContentsImpl::RenderViewCreated() when we create child window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 196283013: Make to call WebContentsImpl::RenderViewCreated() when we create child window. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl_browsertest.cc » ('j') | content/browser/web_contents/web_contents_impl_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

===================================================================

--- content/browser/web_contents/web_contents_impl.cc (revision 256801)

+++ content/browser/web_contents/web_contents_impl.cc (working copy)

@@ -1354,6 +1354,11 @@

new WebContentsImpl(GetBrowserContext(),

params.opener_suppressed ? NULL : this);

+ NotificationService::current()->Notify(

+ NOTIFICATION_WEB_CONTENTS_CREATE_NEW_WINDOW,

+ Source<WebContents>(this),

+ Details<WebContents>(new_contents));

new_contents->GetController().SetSessionStorageNamespace(

partition_id,

session_storage_namespace);

@@ -1377,6 +1382,7 @@

if (params.disposition == NEW_BACKGROUND_TAB)

create_params.initially_hidden = true;

new_contents->Init(create_params);

+ new_contents->RenderViewCreated(new_contents->GetRenderViewHost());

// Save the window for later if we're not suppressing the opener (since it

// will be shown immediately).