fix #552, Object members on native types

tool/input_sdk/private/ddc_runtime/classes.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// This library defines the operations that define and manipulate Dart
 /// classes.  Included in this are:
 ///   - Generics
 ///   - Class metadata
 ///   - Extension methods
 ///
@@ skipping 45 matching lines @@
       }
       return s;
     }
   });
 
   // Save mixins for reflection
   Mixin[$_mixins] = $mixins;
   return Mixin;
 })()''');
 
+
+/// The Symbol for storing type arguments on a specialized generic type.
+final _mixins = JS('', 'Symbol("mixins")');
+
 getMixins(clazz) => JS('', '$clazz[$_mixins]');
 
-getImplements(clazz) => JS('', '$clazz[$implements_]');
+@JSExportName('implements')
+final _implements = JS('', 'Symbol("implements")');
+
+getImplements(clazz) => JS('', '#[#]', clazz, _implements);
 
 /// The Symbol for storing type arguments on a specialized generic type.
 final _typeArguments = JS('', 'Symbol("typeArguments")');
+
 final _originalDeclaration = JS('', 'Symbol("originalDeclaration")');
 
 /// Memoize a generic type constructor function.
 generic(typeConstructor) => JS('', '''(() => {
   let length = $typeConstructor.length;
   if (length < 1) {
     $throwInternalError('must have at least one generic type argument');
   }
   let resultMap = new Map();
   function makeGenericType(...args) {
     if (args.length != length && args.length != 0) {
       $throwInternalError('requires ' + length + ' or 0 type arguments');
     }
-    while (args.length < length) args.push($dynamicR);
+    while (args.length < length) args.push($dynamic);
 
     let value = resultMap;
     for (let i = 0; i < length; i++) {
       let arg = args[i];
       if (arg == null) {
         $throwInternalError('type arguments should not be null: '
                           + $typeConstructor);
       }
       let map = value;
       value = map.get(arg);
@@ skipping 152 matching lines @@
   let initMethod = proto[$name];
   let ctor = function() { return initMethod.apply(this, arguments); };
   ctor.prototype = proto;
   // Use defineProperty so we don't hit a property defined on Function,
   // like `caller` and `arguments`.
   $defineProperty($clazz, $name, { value: ctor, configurable: true });
 })()''');
 
 final _extensionType = JS('', 'Symbol("extensionType")');
 
-getExtensionType(obj) => JS('', '$obj[$_extensionType]');
+getExtensionType(obj) => JS('', '#[#]', obj, _extensionType);
 
 final dartx = JS('', 'dartx');
 
-getExtensionSymbol(name) => JS('', '''(() => {
-  let sym = $dartx[$name];
-  if (!sym) $dartx[$name] = sym = Symbol('dartx.' + $name.toString());
+getExtensionSymbol(name) {
+  var sym = JS('', 'dartx[#]', name);
+  if (sym == null) {
+    sym = JS('', 'Symbol("dartx." + #.toString())', name);
+    JS('', 'dartx[#] = #', name, sym);
+  }
   return sym;
-})()''');
+}
 
-defineExtensionNames(names) => JS('', '$names.forEach($getExtensionSymbol)');
+defineExtensionNames(names) =>
+    JS('', '#.forEach(#)', names, getExtensionSymbol);
 
 // Install properties in prototype order.  Properties / descriptors from
 // more specific types should overwrite ones from less specific types.
-_installProperties(jsProto, extProto) => JS('', '''(() => {
-  if (extProto !== $Object.prototype && extProto !== jsProto) {
-    $_installProperties(jsProto, extProto.__proto__);
+_installProperties(jsProto, extProto) {
+  var coreObjProto = JS('', '#.prototype', Object);
+  if (JS('bool', '# === #', extProto, coreObjProto)) {
+    // core.Object members need to be copied from the non-symbol name to the
+    // symbol name.
+    for (var name in getOwnPropertyNames(coreObjProto)) {
+      var desc = getOwnPropertyDescriptor(coreObjProto, name);
+      defineProperty(jsProto, getExtensionSymbol(name), desc);
+    }
+    return;
   }
-  $copyTheseProperties(jsProto, extProto, $getOwnPropertySymbols(extProto));
-})()''');
+  if (JS('bool', '# !== #', jsProto, extProto)) {
+    _installProperties(jsProto, JS('', '#.__proto__', extProto));
+  }
+  copyTheseProperties(jsProto, extProto, getOwnPropertySymbols(extProto));
+}
 
 ///
 /// Copy symbols from the prototype of the source to destination.
 /// These are the only properties safe to copy onto an existing public
 /// JavaScript class.
 ///
 registerExtension(jsType, dartExtType) => JS('', '''(() => {
   // TODO(vsm): Not all registered js types are real.
   if (!jsType) return;
 
@@ skipping 76 matching lines @@
 })()''');
 
 /// Sets the element type of a list literal.
 list(obj, elementType) =>
     JS('', '$setType($obj, ${getGenericClass(JSArray)}($elementType))');
 
 setBaseClass(derived, base) => JS('', '''(() => {
   // Link the extension to the type it's extending as a base class.
   $derived.prototype.__proto__ = $base.prototype;
 })()''');