Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1962723003: Make SkAssertResult work with SK_WARN_UNUSED_RESULT in Release on gcc (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/core/SkTypes.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bsalomon
gcc is a little harder to fool than clang.
4 years, 7 months ago (2016-05-09 18:04:12 UTC) #3
reed1
IHGCC lgtm
4 years, 7 months ago (2016-05-09 19:10:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962723003/1
4 years, 7 months ago (2016-05-09 19:13:04 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 19:35:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1b4c01c66081cd163535eab21b29a3996b01a6cf

Powered by Google App Engine
This is Rietveld 408576698