Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1962723002: [turbofan] Implement top-level lookup slot declaration. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Implement top-level lookup slot declaration. This implements declaration of lookup slots for variables and functions within optimized code. Such a declaration only appears with top-level eval code, which we only recently started handling in TurboFan. R=jarin@chromium.org Committed: https://crrev.com/7b37243358887b87704a216faf082a00e6970d7e Cr-Commit-Position: refs/heads/master@{#36125}

Patch Set 1 #

Patch Set 2 : Skip timeouts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -9 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +26 lines, -6 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/mjsunit/ignition/regress-599001-verifyheap.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/mozilla/mozilla.status View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-09 16:02:40 UTC) #1
Benedikt Meurer
Nice. LGTM!
4 years, 7 months ago (2016-05-10 08:15:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962723002/20001
4 years, 7 months ago (2016-05-10 08:17:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 08:19:04 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 08:19:30 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7b37243358887b87704a216faf082a00e6970d7e
Cr-Commit-Position: refs/heads/master@{#36125}

Powered by Google App Engine
This is Rietveld 408576698