Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1962703002: Revert of Re-enable complex text path on android (Closed)

Created:
4 years, 7 months ago by eae
Modified:
4 years, 7 months ago
Reviewers:
drott
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable complex text path on android (patchset #1 id:1 of https://codereview.chromium.org/1949053002/ ) Reason for revert: Memory and perf regression BUG=609940 Original issue's description: > Re-enable complex text path on android > > Trying to re-enable the complex text path on Android now that hb_font_t > is cached with the user data container instead of the hb_face_t object. > > This should result in lower memory usage for the complex text code path, > we'll watch the memory bots though and revert as needed if it regresses. > > BUG=577306 > R=drott@chromium.org > > Committed: https://crrev.com/9af72a88ea5b39c2c36c99f8b091c5feae82ef7d > Cr-Commit-Position: refs/heads/master@{#392010} TBR=drott@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=577306 Committed: https://crrev.com/5f972017cef8b77b697e0b339e1bba0c8897af00 Cr-Commit-Position: refs/heads/master@{#392346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
eae
Created Revert of Re-enable complex text path on android
4 years, 7 months ago (2016-05-09 15:32:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962703002/1
4 years, 7 months ago (2016-05-09 15:32:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 17:10:50 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 17:12:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f972017cef8b77b697e0b339e1bba0c8897af00
Cr-Commit-Position: refs/heads/master@{#392346}

Powered by Google App Engine
This is Rietveld 408576698