Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1962693002: [libfuzzer] Adding and registering ASan Debug build. (Closed)

Created:
4 years, 7 months ago by mmoroz
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use BUILD_CONFIG value to determine build_dir correctly. #

Patch Set 3 : Rebase. #

Patch Set 4 : Re-run recipe_simulation_test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -16 lines) Patch
M masters/master.chromium.fyi/master.cfg View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M masters/master.chromium.fyi/slaves.cfg View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_libfuzzer.py View 1 2 chunks +18 lines, -1 line 0 comments Download
A + scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_ASan_Debug.json View 1 2 3 10 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 25 (10 generated)
mmoroz
4 years, 7 months ago (2016-05-09 14:51:06 UTC) #1
Oliver Chang
https://codereview.chromium.org/1962693002/diff/1/scripts/slave/recipes/chromium_libfuzzer.py File scripts/slave/recipes/chromium_libfuzzer.py (right): https://codereview.chromium.org/1962693002/diff/1/scripts/slave/recipes/chromium_libfuzzer.py#newcode121 scripts/slave/recipes/chromium_libfuzzer.py:121: build_dir=api.path['slave_build'].join('src', 'out', 'Release'), I think this might need to ...
4 years, 7 months ago (2016-05-09 16:46:30 UTC) #2
Dirk Pranke
lgtm w/ ochang's correction.
4 years, 7 months ago (2016-05-09 18:41:03 UTC) #3
mmoroz
https://codereview.chromium.org/1962693002/diff/1/scripts/slave/recipes/chromium_libfuzzer.py File scripts/slave/recipes/chromium_libfuzzer.py (right): https://codereview.chromium.org/1962693002/diff/1/scripts/slave/recipes/chromium_libfuzzer.py#newcode121 scripts/slave/recipes/chromium_libfuzzer.py:121: build_dir=api.path['slave_build'].join('src', 'out', 'Release'), On 2016/05/09 16:46:30, Oliver Chang wrote: ...
4 years, 7 months ago (2016-05-10 09:11:59 UTC) #4
Oliver Chang
lgtm
4 years, 7 months ago (2016-05-10 15:52:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962693002/20001
4 years, 7 months ago (2016-05-10 15:57:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/4712) Build Try Recipe ...
4 years, 7 months ago (2016-05-10 15:58:37 UTC) #10
mmoroz
On 2016/05/10 15:58:37, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 7 months ago (2016-05-10 16:03:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962693002/20001
4 years, 7 months ago (2016-05-10 18:04:02 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/4716) Build Try Recipe ...
4 years, 7 months ago (2016-05-10 18:05:14 UTC) #15
mmoroz
Master has been restarted, trying again.
4 years, 7 months ago (2016-05-12 09:09:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962693002/20001
4 years, 7 months ago (2016-05-12 09:09:45 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/4778)
4 years, 7 months ago (2016-05-12 09:10:55 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962693002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962693002/60001
4 years, 7 months ago (2016-05-12 09:34:34 UTC) #23
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 09:38:10 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300556

Powered by Google App Engine
This is Rietveld 408576698