Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1962683002: fix linux warnings (Closed)

Created:
4 years, 7 months ago by caryclark
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com, rmistry
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

fix linux warnings The Skia variant generates a couple of warnings on the linux build. One of the warning silenced is an unused variable. Once PDFs are identified that exercise this variable, the dummy code will be replaced. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/690a99c20a0f4cb67a386e64d711023dd8e15bed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M core/fxge/skia/fx_skia_device.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
On 2016/05/09 14:54:17, rmistry wrote: > Description was changed from > > ========== > fix ...
4 years, 7 months ago (2016-05-09 15:29:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962683002/1
4 years, 7 months ago (2016-05-09 16:53:08 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 17:08:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/690a99c20a0f4cb67a386e64d711023dd8e1...

Powered by Google App Engine
This is Rietveld 408576698