Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 1962663002: [fullcodegen] Factor out VisitProperty from architectures. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
titzer, mvstanton
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Factor out VisitProperty from architectures. This makes the aforementioned visitation function independent of the target architecture by leveraging existing abstractions. R=mvstanton@chromium.org Committed: https://crrev.com/d0e84c8ebd43b3da41e4154f349f42de60448cb2 Cr-Commit-Position: refs/heads/master@{#36111}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -332 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +35 lines, -0 lines 1 comment Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-09 14:13:10 UTC) #3
titzer
lgtm https://codereview.chromium.org/1962663002/diff/1/src/full-codegen/full-codegen.cc File src/full-codegen/full-codegen.cc (right): https://codereview.chromium.org/1962663002/diff/1/src/full-codegen/full-codegen.cc#newcode823 src/full-codegen/full-codegen.cc:823: void FullCodeGenerator::VisitProperty(Property* expr) { Why would do this? ...
4 years, 7 months ago (2016-05-09 14:15:33 UTC) #5
mvstanton
lgtm
4 years, 7 months ago (2016-05-09 14:17:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962663002/1
4 years, 7 months ago (2016-05-09 14:29:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 14:32:34 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 14:33:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0e84c8ebd43b3da41e4154f349f42de60448cb2
Cr-Commit-Position: refs/heads/master@{#36111}

Powered by Google App Engine
This is Rietveld 408576698