chrome/test/data/webui/media_router/media_router_container_search_tests.js - Issue 1962643005: [Media Router WebUI] Fix search input positioning when list scrolls.

Unified Diff: chrome/test/data/webui/media_router/media_router_container_search_tests.js

Issue 1962643005: [Media Router WebUI] Fix search input positioning when list scrolls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CSS attribute instead of JS binding Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/webui/media_router/media_router_container_search_tests.js

diff --git a/chrome/test/data/webui/media_router/media_router_container_search_tests.js b/chrome/test/data/webui/media_router/media_router_container_search_tests.js

index 5b5f72a999479802d0b412396397787427333744..ad304e64202c95e06144065f84cdc5b7f4de0ae8 100644

--- a/chrome/test/data/webui/media_router/media_router_container_search_tests.js

+++ b/chrome/test/data/webui/media_router/media_router_container_search_tests.js

@@ -167,7 +167,7 @@ cr.define('media_router_container_search', function() {

container.$$('#sink-list').querySelectorAll('paper-item');

assertEquals(fakeSinkList.length, sinkList.length);

MockInteractions.tap(container.$['sink-search-icon']);

- setTimeout(function() {

+ chainOnAnimationPromise(function() {

var searchResults =

container.$$('#search-results').querySelectorAll('paper-item');

assertEquals(fakeSinkList.length, searchResults.length);

@@ -181,7 +181,7 @@ cr.define('media_router_container_search', function() {

var searchInput = container.$['sink-search-input'];

searchInput.value = 'no existing sink';

- setTimeout(function() {

+ chainOnAnimationPromise(function() {

var searchResults =

container.$$('#search-results').querySelectorAll('paper-item');

assertEquals(1, searchResults.length);

@@ -197,7 +197,7 @@ cr.define('media_router_container_search', function() {

var searchInput = container.$['sink-search-input'];

searchInput.value = fakeSinkList[0].name;

- setTimeout(function() {

+ chainOnAnimationPromise(function() {

var searchResults =

container.$$('#search-results').querySelectorAll('paper-item');

assertEquals(1, searchResults.length);

@@ -213,7 +213,7 @@ cr.define('media_router_container_search', function() {

var searchInput = container.$['sink-search-input'];

searchInput.value = 'no existing sink';

- setTimeout(function() {

+ chainOnAnimationPromise(function() {

var searchResults =

container.$$('#search-results').querySelectorAll('paper-item');

container.addEventListener(

@@ -232,7 +232,7 @@ cr.define('media_router_container_search', function() {

var searchInput = container.$['sink-search-input'];

searchInput.value = foundSink.name;

- setTimeout(function() {

+ chainOnAnimationPromise(function() {

var searchResults =

container.$$('#search-results').querySelectorAll('paper-item');

MockInteractions.tap(searchResults[0]);

@@ -261,13 +261,13 @@ cr.define('media_router_container_search', function() {

var searchInput = container.$['sink-search-input'];

searchInput.value = foundSink.name;

- setTimeout(function() {

+ chainOnAnimationPromise(function() {

var searchResults =

container.$$('#search-results').querySelectorAll('paper-item');

MockInteractions.tap(searchResults[0]);

MockInteractions.tap(

container.$['container-header'].$$('#back-button'));

- setTimeout(function() {

+ chainOnAnimationPromise(function() {

checkCurrentView(media_router.MediaRouterView.SINK_LIST);

checkSpinningSinkInSinkList(

pseudoSink, fakeSinkListWithPseudoSink.length);

@@ -281,7 +281,7 @@ cr.define('media_router_container_search', function() {

var searchInput = container.$['sink-search-input'];

searchInput.value = foundSink.name;

- setTimeout(function() {

+ chainOnAnimationPromise(function() {

var searchResults =

container.$$('#search-results').querySelectorAll('paper-item');

MockInteractions.tap(searchResults[0]);

@@ -302,7 +302,7 @@ cr.define('media_router_container_search', function() {

var searchInput = container.$['sink-search-input'];

searchInput.value = foundSink.name;

- setTimeout(function() {

+ chainOnAnimationPromise(function() {

var searchResults =

container.$$('#search-results').querySelectorAll('paper-item');

MockInteractions.tap(searchResults[0]);

@@ -327,7 +327,7 @@ cr.define('media_router_container_search', function() {

var searchInput = container.$['sink-search-input'];

searchInput.value = foundSink.name;

- setTimeout(function() {

+ chainOnAnimationPromise(function() {

var searchResults =

container.$$('#search-results').querySelectorAll('paper-item');

MockInteractions.tap(searchResults[0]);

@@ -339,7 +339,7 @@ cr.define('media_router_container_search', function() {

checkCurrentView(media_router.MediaRouterView.ROUTE_DETAILS);

MockInteractions.tap(

container.$['container-header'].$$('#back-button'));

- setTimeout(function() {

+ chainOnAnimationPromise(function() {

checkCurrentView(media_router.MediaRouterView.SINK_LIST);

sinkList =

container.$$('#sink-list').querySelectorAll('paper-item');

@@ -410,7 +410,7 @@ cr.define('media_router_container_search', function() {

var searchInput = container.$['sink-search-input'];

searchInput.value = foundSink.name;

- setTimeout(function() {

+ chainOnAnimationPromise(function() {

var searchResults =

container.$$('#search-results').querySelectorAll('paper-item');

MockInteractions.tap(searchResults[0]);

@@ -437,7 +437,7 @@ cr.define('media_router_container_search', function() {

var searchInput = container.$['sink-search-input'];

searchInput.value = foundSink.name;

- setTimeout(function() {

+ chainOnAnimationPromise(function() {

var noMatches = container.$$('#no-search-matches');

var searchResults = container.$$('#search-results');

checkElementVisible(noMatches, true);

« no previous file with comments | « chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js ('k') | no next file » | no next file with comments »