Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1962633002: Adds `DartOptions` to generic method syntax tests. (Closed)

Created:
4 years, 7 months ago by eernst
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adds `DartOptions` to generic method syntax tests. This CL adds a `DartOptions` comment to the '--generic-method-syntax' related tests specifying that option, and changes the entries for these tests in status files to expect success for dart2js except when running in a browser (where the option gets dropped rather than passed on to the compiler). BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/ae31db041d192232c2e65e10577c17689be6e747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M tests/language/generic_functions_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/generic_local_functions_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/generic_methods_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/generic_sends_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language.status View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
eernst
This CL uses a `DartOptions` comment to make test.py pass '--generic-method-syntax' to dart2js when running ...
4 years, 7 months ago (2016-05-09 13:32:11 UTC) #3
floitsch
LGTM. Just fix the documentation for DartOptions.
4 years, 7 months ago (2016-05-09 15:04:58 UTC) #5
eernst
4 years, 7 months ago (2016-05-09 15:15:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ae31db041d192232c2e65e10577c17689be6e747 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698