Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1962623002: Relayout an object that becomes a spanner. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
wkorman, eae, szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relayout an object that becomes a spanner. It may be possible to collapse margins through a zero-height regular block, but if it is turned into a spanner, this is no longer possible, because it then becomes a BFC root. An object that becomes a spanner also gets a new containing block, which may affect its size. In other words, there are good reasons to make sure that objects that become spanners get relaid out. Note that we already had code in place (in willBeRemovedFromTree()) that scheduled for relayout in the opposite case, i.e. when an object ceased to be a spanner. BUG=610033 Committed: https://crrev.com/d7955c040f7907aceb6584a25215570614a8fe83 Cr-Commit-Position: refs/heads/master@{#392438}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-09 18:56:14 UTC) #2
eae
LGTM
4 years, 7 months ago (2016-05-09 20:50:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962623002/1
4 years, 7 months ago (2016-05-09 20:51:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 22:09:03 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 22:10:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7955c040f7907aceb6584a25215570614a8fe83
Cr-Commit-Position: refs/heads/master@{#392438}

Powered by Google App Engine
This is Rietveld 408576698