Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1962593002: Convert track-webvtt-tc[008-010] tests to testharness.js (Closed)

Created:
4 years, 7 months ago by Srirama
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert track-webvtt-tc[008-010] tests to testharness.js Cleaning up track-webvtt-tc[008-010] tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/385c4876b0872dda62dc8e37511c5910e74216a8 Cr-Commit-Position: refs/heads/master@{#395584}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : address comments #

Patch Set 3 : fix test failure #

Messages

Total messages: 26 (15 generated)
Srirama
PTAL
4 years, 7 months ago (2016-05-19 18:54:34 UTC) #4
mlamouri (slow - plz ping)
https://codereview.chromium.org/1962593002/diff/20001/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc008-timings-no-hours.html File third_party/WebKit/LayoutTests/media/track/track-webvtt-tc008-timings-no-hours.html (right): https://codereview.chromium.org/1962593002/diff/20001/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc008-timings-no-hours.html#newcode61 third_party/WebKit/LayoutTests/media/track/track-webvtt-tc008-timings-no-hours.html:61: assert_cues_equal(cues, expected); Same as the other review, you can ...
4 years, 7 months ago (2016-05-20 12:44:26 UTC) #5
Srirama
https://codereview.chromium.org/1962593002/diff/20001/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc008-timings-no-hours.html File third_party/WebKit/LayoutTests/media/track/track-webvtt-tc008-timings-no-hours.html (right): https://codereview.chromium.org/1962593002/diff/20001/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc008-timings-no-hours.html#newcode61 third_party/WebKit/LayoutTests/media/track/track-webvtt-tc008-timings-no-hours.html:61: assert_cues_equal(cues, expected); On 2016/05/20 12:44:26, Mounir Lamouri wrote: > ...
4 years, 7 months ago (2016-05-20 13:37:08 UTC) #8
mlamouri (slow - plz ping)
lgtm
4 years, 7 months ago (2016-05-23 23:17:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962593002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962593002/80001
4 years, 7 months ago (2016-05-24 03:16:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/232682)
4 years, 7 months ago (2016-05-24 04:21:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962593002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962593002/100001
4 years, 7 months ago (2016-05-24 07:16:12 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/234311)
4 years, 7 months ago (2016-05-24 08:24:01 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962593002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962593002/120001
4 years, 7 months ago (2016-05-24 13:12:29 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:120001)
4 years, 7 months ago (2016-05-24 13:16:17 UTC) #24
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 13:17:33 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/385c4876b0872dda62dc8e37511c5910e74216a8
Cr-Commit-Position: refs/heads/master@{#395584}

Powered by Google App Engine
This is Rietveld 408576698