Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1962563003: [x64] Fix testw with immediates. (Closed)

Created:
4 years, 7 months ago by epertoso
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Fix testw with immediates. Assembler::testw(Register, Immediate) and Assembler::testw(const Operand&, Immediate) were emitting only the first 8 bits of a 16-bit immediate, causing unexpected crashes. This went unnoticed because before http://crrev.com/1948453002 no compiler was using them. Committed: https://crrev.com/99230f8d0e114d5a31cf3696a012522d5ecc1ccf Cr-Commit-Position: refs/heads/master@{#36110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M src/x64/assembler-x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962563003/1
4 years, 7 months ago (2016-05-09 13:26:33 UTC) #2
epertoso
4 years, 7 months ago (2016-05-09 13:27:14 UTC) #4
Jarin
lgtm. Thanks.
4 years, 7 months ago (2016-05-09 13:28:39 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-09 13:48:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962563003/1
4 years, 7 months ago (2016-05-09 13:52:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 13:54:42 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 13:55:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99230f8d0e114d5a31cf3696a012522d5ecc1ccf
Cr-Commit-Position: refs/heads/master@{#36110}

Powered by Google App Engine
This is Rietveld 408576698