Fix ImageDecoder::frameIsCompleteAtIndex - fully received instead of decoded.

third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp

Index: third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
diff --git a/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp b/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
index 3c51d4d721e9ce215e416a24110b7697c9c91a37..a374daebdfafe43aa1c79f080ba766da3575e3f2 100644
--- a/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
+++ b/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
@@ -86,7 +86,16 @@ void testByteByByteDecode(DecoderCreator createDecoder, const char* file, size_t
         if (!decoder->isSizeAvailable())
             continue;
 
+        bool frameIsFullyReceived = decoder->frameIsFullyReceivedAtIndex(frameCount - 1);
         ImageFrame* frame = decoder->frameBufferAtIndex(frameCount - 1);
+
+        if (frameIsFullyReceived)
+            ASSERT_TRUE(decoder->frameIsCompleteAtIndex(frameCount - 1) || decoder->failed());
+
+        for (size_t i = 0; i < framesDecoded; ++i) {

[aleksandar.stojiljkovic, 2016/06/06 16:36:38]

This is partly addressed in DeferredImageDecoderTest but here it is doing it
byte by byte.
It is related to the behavior expected in
DeferredImageDecoder::prepareLazyDecodedFrames - all the frames before partially
available frame are expected to be fully received. 

[Peter Kasting, 2016/06/10 00:10:02]

Is that guaranteed for things like ICO where later frames may appear before
earlier ones?  In theory, we could get enough data to completely decode ICO
frome 2 before frame 1.  Or does this never happen, because of your changes (in
your other CL) to make ICO report that only the first n frames are received?

[aleksandar.stojiljkovic, 2016/06/10 21:51:08]

This never happens now after the other CL.

+            ASSERT_TRUE(decoder->frameIsFullyReceivedAtIndex(i));
+        }
+
         if (frame && frame->getStatus() == ImageFrame::FrameComplete && framesDecoded < frameCount)
             ++framesDecoded;
     }