third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h - Issue 1962563002: Fix ImageDecoder::frameIsCompleteAtIndex - fully received instead of decoded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

Issue 1962563002: Fix ImageDecoder::frameIsCompleteAtIndex - fully received instead of decoded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: better check in unit test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h ('k') | third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h » ('j') | third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

diff --git a/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h b/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

index 05fff2ecdc2786020b8829daa16fd3241bf81bc8..350eee96dfc9bdcbf1905e297d4bbfb0cec7bedd 100644

--- a/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

+++ b/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

@@ -92,9 +92,13 @@ public:

return m_client->repetitionCount();

}

- bool frameIsCompleteAtIndex(size_t) const override

+ bool frameIsFullyReceivedAtIndex(size_t index) const override

{

- return m_client->status() == ImageFrame::FrameComplete;

+ // All but the last frame are fully received.

+ // For the last frame use base class implementation.

+ if (index < m_frameBufferCache.size() - 1)

+ return true;

+ return ImageDecoder::frameIsFullyReceivedAtIndex(index);

Peter Kasting 2016/06/10 00:10:02 Nit: Simpler: return (index < m_frameBuff

}

float frameDurationAtIndex(size_t) const override