third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h - Issue 1962563002: Fix ImageDecoder::frameIsCompleteAtIndex - fully received instead of decoded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

Issue 1962563002: Fix ImageDecoder::frameIsCompleteAtIndex - fully received instead of decoded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: extending the scope with naming suggested by @scroggo Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp » ('j') | third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

index f9aa02c42e4c4174ef5844a4f2e57371150e9849..571cf3c733cc17bdd11b139e4facd06806aba093 100644

--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

@@ -49,7 +49,7 @@ public:

String filenameExtension() const override { return "gif"; }

void onSetData(SharedBuffer* data) override;

int repetitionCount() const override;

- bool frameIsCompleteAtIndex(size_t) const override;

+ bool frameIsFullyReceivedAtIndex(size_t) const override;

float frameDurationAtIndex(size_t) const override;

size_t clearCacheExceptFrame(size_t) override;

// CAUTION: setFailed() deletes |m_reader|. Be careful to avoid