Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

Issue 1962563002: Fix ImageDecoder::frameIsCompleteAtIndex - fully received instead of decoded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: extending the scope with naming suggested by @scroggo Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
index 03ca9b2cef22c4cae1967c003bca17facf5ec44b..be91ef07cff75d9d3efea1260530f2f811bec3e1 100644
--- a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
+++ b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
@@ -179,10 +179,10 @@ bool DeferredImageDecoder::frameHasAlphaAtIndex(size_t index) const
return true;
}
-bool DeferredImageDecoder::frameIsCompleteAtIndex(size_t index) const
+bool DeferredImageDecoder::frameIsFullyReceivedAtIndex(size_t index) const
{
if (m_actualDecoder)
- return m_actualDecoder->frameIsCompleteAtIndex(index);
+ return m_actualDecoder->frameIsFullyReceivedAtIndex(index);
if (index < m_frameData.size())
return m_frameData[index].m_isComplete;
return false;
@@ -251,14 +251,14 @@ void DeferredImageDecoder::prepareLazyDecodedFrames()
m_frameData[i].m_haveMetadata = true;
m_frameData[i].m_duration = m_actualDecoder->frameDurationAtIndex(i);
m_frameData[i].m_orientation = m_actualDecoder->orientation();
- m_frameData[i].m_isComplete = m_actualDecoder->frameIsCompleteAtIndex(i);
+ m_frameData[i].m_isComplete = m_actualDecoder->frameIsFullyReceivedAtIndex(i);
}
// The last lazy decoded frame created from previous call might be
// incomplete so update its state.
if (previousSize) {
const size_t lastFrame = previousSize - 1;
- m_frameData[lastFrame].m_isComplete = m_actualDecoder->frameIsCompleteAtIndex(lastFrame);
+ m_frameData[lastFrame].m_isComplete = m_actualDecoder->frameIsFullyReceivedAtIndex(lastFrame);
}
if (m_allDataReceived) {

Powered by Google App Engine
This is Rietveld 408576698